Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/ --- Review request for drill and Venki Korukanti. Repository: drill-git Descripti

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/#review76138 --- exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 11, 2015, 10:22 p.m., Chris Westin wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/SystemRecords.java, > > line 48 > > > > > > This, and all the nested static classes should be separa

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/ --- (Updated March 12, 2015, 5:44 a.m.) Review request for drill and Venki Korukant

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/ --- (Updated March 17, 2015, 1:01 a.m.) Review request for drill and Venki Korukant

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/#review76693 --- Ship it! Just one minor comment; if that works and you can do that,

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/ --- (Updated March 17, 2015, 3:51 p.m.) Review request for drill and Venki Korukant

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/#review76768 --- Ship it! Ship It! - Chris Westin On March 17, 2015, 8:51 a.m., S

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/ --- (Updated March 19, 2015, 8:48 p.m.) Review request for drill and Venki Korukant

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/#review77111 --- exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/Memory

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 19, 2015, 9:27 p.m., Chris Westin wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/MemoryRecord.java, > > line 108 > > > > > > I thought we were going to use "max_heap_size" since t

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/#review77119 --- Can we use the following for column anmes: hostname user_port heap_

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 19, 2015, 3:16 p.m., Jacques Nadeau wrote: > > Can we use the following for column anmes: > > > > hostname > > user_port > > heap_current > > heap_max > > direct_current > > direct_max Doesn't sys.drillbits use host_name? If so, we should be consistent with that. - Chris

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 19, 2015, 10:16 p.m., Jacques Nadeau wrote: > > Can we use the following for column anmes: > > > > hostname > > user_port > > heap_current > > heap_max > > direct_current > > direct_max > > Chris Westin wrote: > Doesn't sys.drillbits use host_name? If so, we should be consistent

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/ --- (Updated March 20, 2015, 12:02 a.m.) Review request for drill and Venki Korukan

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31938/#review77148 --- One minor comment about a comment, but looks good otherwise. exec/

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 20, 2015, 1:28 a.m., Chris Westin wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java, > > line 48 > > > > > > Shouldn't this be a TODO? Of course, inquiring minds

Re: Review Request 31938: DRILL-2275: Need implementations of sys tables for drill memory and threads profiles

> On March 19, 2015, 6:28 p.m., Chris Westin wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/store/sys/TestSystemTable.java, > > line 48 > > > > > > Shouldn't this be a TODO? Of course, inquiring minds