Re: Review Request 32867: DRILL-2695: Add support for large in lists via values operator

2015-04-12 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32867/ --- (Updated April 13, 2015, midnight) Review request for drill, Aman Sinha and

Re: Review Request 32867: DRILL-2695: Add support for large in lists via values operator

2015-04-07 Thread Jacques Nadeau
On April 6, 2015, 3:51 a.m., Aman Sinha wrote: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillValuesRel.java, line 60 https://reviews.apache.org/r/32867/diff/2/?file=915514#file915514line60 The use of JSONOptions has some advantages in terms of

Re: Review Request 32867: DRILL-2695: Add support for large in lists via values operator

2015-04-07 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32867/ --- (Updated April 7, 2015, 7:25 p.m.) Review request for drill, Aman Sinha and

Re: Review Request 32867: DRILL-2695: Add support for large in lists via values operator

2015-04-07 Thread Aman Sinha
On April 6, 2015, 3:51 a.m., Aman Sinha wrote: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillValuesRel.java, line 60 https://reviews.apache.org/r/32867/diff/2/?file=915514#file915514line60 The use of JSONOptions has some advantages in terms of

Re: Review Request 32867: DRILL-2695: Add support for large in lists via values operator

2015-04-07 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32867/#review79274 --- Ship it! Ship It! - Aman Sinha On April 7, 2015, 7:25 p.m.,

Re: Review Request 32867: DRILL-2695: Add support for large in lists via values operator

2015-04-06 Thread Hanifi Gunes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32867/#review79089 ---

Re: Review Request 32867: DRILL-2695: Add support for large in lists via values operator

2015-04-05 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32867/ --- (Updated April 5, 2015, 11:49 p.m.) Review request for drill, Aman Sinha and