Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/ --- (Updated May 9, 2015, 6:48 p.m.) Review request for drill, Hanifi Gunes, Jacque

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

> On May 5, 2015, 11:19 p.m., Jacques Nadeau wrote: > > Let's just have one exception OutOfMemoryException and make it a > > RuntimeException. I don't know what the purpose of having two different > > ones is. > > Jacques Nadeau wrote: > I meant to add: I don't think we need this to ever

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/ --- (Updated May 6, 2015, 7:10 p.m.) Review request for drill, Hanifi Gunes, Jacque

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/#review82691 --- I reviewed vector changes only. Partial +1 for VV changes. exec/ja

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/ --- (Updated May 6, 2015, 4:04 p.m.) Review request for drill, Hanifi Gunes, Jacque

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/ --- (Updated May 6, 2015, 3:37 p.m.) Review request for drill, Hanifi Gunes, Jacque

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

> On May 5, 2015, 11:19 p.m., Jacques Nadeau wrote: > > Let's just have one exception OutOfMemoryException and make it a > > RuntimeException. I don't know what the purpose of having two different > > ones is. > > Jacques Nadeau wrote: > I meant to add: I don't think we need this to ever

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

> On May 5, 2015, 11:19 p.m., Jacques Nadeau wrote: > > Let's just have one exception OutOfMemoryException and make it a > > RuntimeException. I don't know what the purpose of having two different > > ones is. I meant to add: I don't think we need this to ever be a caught exception. - Jacqu

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/#review82606 --- Let's just have one exception OutOfMemoryException and make it a Ru

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

> On May 5, 2015, 8:24 p.m., Steven Phillips wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java, > > line 53 > > > > > > Does this exception need to be part of the signature? Is

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/#review82579 --- Ship it! Ship It! - Steven Phillips On May 5, 2015, 2:51 a.m., a

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

> On May 5, 2015, 8:24 p.m., Steven Phillips wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java, > > line 53 > > > > > > Does this exception need to be part of the signature? Is

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

> On May 5, 2015, 8:24 p.m., Steven Phillips wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java, > > line 210 > > > > > > Should we also catch OutOfMemoryRuntimeException? Yes -

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/#review82576 --- exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/For

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/#review82574 --- exec/java-exec/src/main/java/org/apache/drill/exec/vector/Allocatio

Re: Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/ --- (Updated May 5, 2015, 2:51 a.m.) Review request for drill, Hanifi Gunes, Jacque

Review Request 33829: DRILL-2757: Verify operators correctly handle low memory conditions and cancellations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33829/ --- Review request for drill, Hanifi Gunes, Jacques Nadeau, and Steven Phillips. Bu