Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type && instantiate its children upon construction

2015-05-22 Thread Mehant Baid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34499/#review85012 --- Ship it! Ship It! - Mehant Baid On May 22, 2015, 9:19 p.m., Hani

Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type && instantiate its children upon construction

2015-05-22 Thread Hanifi Gunes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34499/ --- (Updated May 22, 2015, 9:19 p.m.) Review request for drill and Mehant Baid. C

Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type && instantiate its children upon construction

2015-05-22 Thread Hanifi Gunes
> On May 21, 2015, 10:42 p.m., Mehant Baid wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java, > > line 145 > > > > > > In which case where we creating vector with Late t

Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type && instantiate its children upon construction

2015-05-21 Thread Mehant Baid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34499/#review84807 --- Can you add a unit test like the one mentioned in the JIRA report fo

Re: Review Request 34499: DRILL-3032: repeated vectors should handle late type && instantiate its children upon construction

2015-05-20 Thread Hanifi Gunes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34499/ --- (Updated May 20, 2015, 9:39 p.m.) Review request for drill and Mehant Baid. C