Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35163/#review87636 --- Ship it! Ship It! - Aman Sinha On June 11, 2015, 5:56 p.m., Sean

Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35163/ --- (Updated June 11, 2015, 5:56 p.m.) Review request for drill, Aman Sinha and Jin

Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

> On June 11, 2015, 12:24 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillUnionRel.java, > > line 60 > > > > > > I think you should modify the DrillUnionRule to handl

Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35163/#review87496 --- exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/

Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

> On June 9, 2015, 2:15 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillDistinctUnionByUnionAll.java, > > line 34 > > > > > > Have you tried using Calcite's UnionToDi

Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35163/ --- (Updated June 9, 2015, 5:37 p.m.) Review request for drill, Aman Sinha and Jinf

Re: Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35163/#review87120 --- exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/

Review Request 35163: DRILL-1169: Add support for UNION (distinct type)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35163/ --- Review request for drill, Aman Sinha and Jinfeng Ni. Bugs: DRILL-1169 https