Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-15 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/#review88005 --- Ship it! Ship It! - Aman Sinha On June 16, 2015, 12:04 a.m., Sea

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-15 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/ --- (Updated June 16, 2015, 12:04 a.m.) Review request for drill, Aman Sinha and Ji

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-15 Thread Aman Sinha
> On June 12, 2015, 12:24 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java, > > line 171 > > > > > > Can we make this message more desc

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-15 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/ --- (Updated June 15, 2015, 5:38 p.m.) Review request for drill, Aman Sinha and Jin

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-15 Thread Sean Hsuan-Yi Chu
> On June 12, 2015, 12:24 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java, > > line 155 > > > > > > we should check for ROWS and RANGE

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-11 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/#review87660 --- exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/pars

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-11 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/ --- (Updated June 11, 2015, 11:46 p.m.) Review request for drill, Aman Sinha and Ji

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-11 Thread Sean Hsuan-Yi Chu
> On June 11, 2015, 11:20 p.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/UnsupportedOperatorsVisitor.java, > > line 120 > > > > > > Instead of 'disabled' we should be

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-11 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/#review87639 --- exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/pars

Re: Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-11 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/ --- (Updated June 11, 2015, 8:33 p.m.) Review request for drill, Aman Sinha and Jin

Review Request 35365: DRILL-3182, DRILL-3188, DRILL-3195

2015-06-11 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35365/ --- Review request for drill, Aman Sinha and Jinfeng Ni. Bugs: DRILL-3182, DRILL-31