Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38796/ --- Review request for drill and Jinfeng Ni. Repository: drill-git Description --

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38796/ --- (Updated Sept. 27, 2015, 7:50 a.m.) Review request for drill and Jinfeng Ni.

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38796/#review100855 --- I mainly looked through the change in planning side. You may have a

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38796/#review100878 --- contrib/storage-hive/core/src/main/java/org/apache/drill/exec/plan

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

> On Sept. 28, 2015, 10:18 p.m., Aman Sinha wrote: > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/ConvertHiveParquetScanToDrillParquetScan.java, > > line 64 > > > > > > The name

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38796/ --- (Updated Sept. 29, 2015, 9:23 a.m.) Review request for drill and Jinfeng Ni.

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

> On Sept. 28, 2015, 2:21 p.m., Jinfeng Ni wrote: > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/ConvertHiveParquetScanToDrillParquetScan.java, > > line 128 > > > > > > the for

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

> On Sept. 29, 2015, 5:18 a.m., Aman Sinha wrote: > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeParquetScan.java, > > line 63 > > > > > > Since the RecordCount is the sam

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38796/#review100991 --- Ship it! Ship It! - Aman Sinha On Sept. 29, 2015, 4:23 p.m., Ve

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

> On Sept. 28, 2015, 10:18 p.m., Aman Sinha wrote: > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeParquetScan.java, > > line 63 > > > > > > Since the RecordCount is the sa

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38796/#review100998 --- Ship it! The revised comments address my comments. contrib/stora

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

> On Sept. 29, 2015, 12:59 p.m., Jinfeng Ni wrote: > > contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/logical/ConvertHiveParquetScanToDrillParquetScan.java, > > line 267 > > > > > > I have

Re: Review Request 38796: DRILL-3209: Support reading Hive tables using Drill's native parquet reader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38796/#review101007 --- Ship it! Looks good. One thing we should do before we merge this i