The etiquette of pocking people on Github and the policy when people stop responding

2019-01-24 Thread Roman Leventov
To foster calmness, respect, and consideration of people's busy schedules I suggest the following etiquette: - When someone showed up in a PR and left some review comments, but didn't explicitly approved the PR, poke them with comments like "@username do you have more comments?" not sooner than in

Re: The etiquette of pocking people on Github and the policy when people stop responding

2019-01-24 Thread Gian Merlino
The timelines you outlined seem quite slow. Especially "if there are enough approvals, a PR could be merged not sooner than in two weeks since they left the last review comment". IMO, rather than delaying patches by so long, a better way to be courteous of a reviewer being too busy to review in a t