Re: Code review

2019-04-25 Thread Roman Leventov
On Wed, 24 Apr 2019 at 00:10, Gian Merlino wrote: > Well, I think this is a good reason to have a robots-only policy for code > style checking. The fact that I am one of the few people that can adhere to > the unwritten style rules, because I've been working on Druid for over 7 > years, means tha

Re: Code review

2019-04-25 Thread David Glasser
As a new contributor, I've actually really appreciated the careful and high quality code reviews I've received (primarily from Jihoon). The real source of friction for me has not been the feedback from developers, but the painfulness of running the tests. - Figuring out how to locally run the ful

Re: Code review

2019-04-25 Thread Julian Hyde
+1 As someone who reviews Druid release candidates but does not develop Druid code, I wish that “mvn test” would “just work”. I can imagine that first-time and occasional contributors are in a similar boat to me. I know this is not an easy thing to achieve, because the test suite also has to w

Re: IntelliJ Ultimate Edition license for Druid developers

2019-04-25 Thread Himanshu
reply from jetbrains on what the license could be used for, "According to our EULA , free Open Source licenses should be used for non-commercial open source development only. They cannot be used for providing paid services, commercial produc

[VOTE] Release Apache Druid (incubating) 0.14.1 [RC1]

2019-04-25 Thread Clint Wylie
Hi all, I have created a build for Apache Druid (incubating) 0.14.1, release candidate 1. Thanks to everyone who has contributed to this release! You can read the proposed release notes here: https://github.com/apache/incubator-druid/issues/7553 The release candidate has been tagged in GitHub as