Re: [DISCUSS] Removing code related to `FireHose`

2022-07-06 Thread Gian Merlino
I am in favor of immediately removing FiniteFirehoseFactory and marking EventReceiverFirehoseFactory deprecated. Then, later on we can remove InputRowParser and EventReceiverFirehoseFactory. On Fri, Jun 24, 2022 at 4:41 AM Abhishek Agarwal wrote: > I didn’t include them (RealtimeIndexTask and >

Re: [DISCUSS] Removing code related to `FireHose`

2022-06-28 Thread Abhishek Agarwal
@Clint Wylie - what do you think of the above proposal? On Fri, Jun 24, 2022 at 5:11 PM Abhishek Agarwal wrote: > I didn’t include them (RealtimeIndexTask and > AppenderatorDriverRealtimeIndexTask) in my previous email because they have > not been marked deprecated yet. We should mark them

Re: [DISCUSS] Removing code related to `FireHose`

2022-06-24 Thread Abhishek Agarwal
I didn’t include them (RealtimeIndexTask and AppenderatorDriverRealtimeIndexTask) in my previous email because they have not been marked deprecated yet. We should mark them deprecated officially in the next release and remove them in the release after that. So looks like the classes that we can

Re: [DISCUSS] Removing code related to `FireHose`

2022-06-23 Thread Clint Wylie
If we remove RealtimeIndexTask and AppenderatorDriverRealtimeIndexTask then we can remove EventReceiverFirehoseFactory. The former was primarily used by tranquility which has been sunset, the latter I'm not sure was ever used for anything. I'm personally in favor of removing both of them since

[DISCUSS] Removing code related to `FireHose`

2022-06-23 Thread Abhishek Agarwal
Hello, The `FiniteFirehoseFactory` and `InputRowParser` classes were deprecated in 0.17.0 (https://github.com/apache/druid/pull/8823) in favour of `InputSource`. 0.17.0 was released more than 2 years ago in Jan 2020. I think it is about time that we remove this code entirely. Removing