[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-406774449 You are welcome. In the process, I also learned a lot. :+1:

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-406767668 Hi, @leventov . Thanks for your review. The `RedundantTypeArguments` has been added as an ERROR level check and `teamcity`

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-406300864 @leventov It seems that both travis and teamcity have succeeded. Any other good suggestions?

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-405974955 Hi, @leventov . It has been fixed. BTW, [jobs-405249198](https://travis-ci.org/apache/incubator-druid/jobs/405249198)

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-405439513 @leventov PTAL. 1. Set the level of `ToArrayCallWithZeroLengthArrayArgument` inspection as `warning`, because use

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-405040192 Sorry, i didn't notice it. I will fix it. Thanks for your comments. @leventov

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-404816519 Hi, @jihoonson . [jobs-403482349](https://travis-ci.org/apache/incubator-druid/jobs/403482349) failed again.. Could you

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-404354126 @leventov You are welcome. The amount of code is large and very troublesome. May have to trouble you. :+1:

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-404224485 [job-402722329](https://travis-ci.org/apache/incubator-druid/jobs/402722329) and