[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403171434 @surekhasaharan could you please merge in master again to this branch, so you get the benefit of #5959? Hopefully that should be enough

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403171386 Got one of these too. ``` testBySegmentResultsWithAllFiltersWithExtractionFns[config=v2ParallelCombine, runner=rtIndex](io.dr

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403134175 @surekhasaharan The TeamCity error looks legit. It's complaining that this method isn't used anymore: ``` public static Virt

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403133666 Saw this in travis, restarting. ```Failed tests: BlockingPoolTest.testConcurrentBatchClose:266 expected:<5> but was:<0>

[GitHub] gianm commented on issue #5931: Support limit for timeseries query (#5894)

2018-07-06 Thread GitBox
gianm commented on issue #5931: Support limit for timeseries query (#5894) URL: https://github.com/apache/incubator-druid/pull/5931#issuecomment-403122325 LGTM, trying to re-run the checks (they lost track of what repo we were on)