[GitHub] jihoonson commented on issue #5471: Implement force push down for nested group by query

2018-07-13 Thread GitBox
jihoonson commented on issue #5471: Implement force push down for nested group by query URL: https://github.com/apache/incubator-druid/pull/5471#issuecomment-404918165 @samarthjain not really.. Sorry for the delayed review. I've been quite busy for our next minor release (0.12.2). I'll tak

[GitHub] jihoonson commented on issue #5471: Implement force push down for nested group by query

2018-07-19 Thread GitBox
jihoonson commented on issue #5471: Implement force push down for nested group by query URL: https://github.com/apache/incubator-druid/pull/5471#issuecomment-406445172 Hi @samarthjain, sorry for the delay. I'm looking at this PR again, and the size of this PR looks huge. Would you check th

[GitHub] jihoonson commented on issue #5471: Implement force push down for nested group by query

2018-07-20 Thread GitBox
jihoonson commented on issue #5471: Implement force push down for nested group by query URL: https://github.com/apache/incubator-druid/pull/5471#issuecomment-406691347 @samarthjain thanks. It looks the huge patch size is because of test data. I think it's fine. --