8399 Migrating Guava to Caffeine

2019-12-27 Thread JJ Meyer
Hello all, I'm planning on contributing for the first time. I'm working on https://github.com/apache/druid/issues/8399. No issues seem to occur when replacing guava with caffeine in any of the classes posted in the issue with exception of the class, OnHeapLoadingCache. I wanted to post something

Re: 8399 Migrating Guava to Caffeine

2020-01-05 Thread Gian Merlino
Hey JJ, I think your idea of adding a new option and deprecating "guava" is a good way forward. Gian On Fri, Dec 27, 2019 at 7:50 AM JJ Meyer wrote: > Hello all, > > I'm planning on contributing for the first time. I'm working on > https://github.com/apache/druid/issues/8399. No issues seem to

Re: 8399 Migrating Guava to Caffeine

2020-01-06 Thread Roman Leventov
To avoid lingering of Guava for a few more Druid releases in code, the "guava" config value could just forcibly use caffeine cache, concurrencyLevel parameter ignored, and appropriate warning messages logged. There is no harm in this, Caffeine's concurrency is practically "elastic" and doesn't dema

Re: 8399 Migrating Guava to Caffeine

2020-01-06 Thread Gian Merlino
That's a good suggestion, especially since the extension has this note "Please note that this is an experimental module and the development/testing still at early stage. Feel free to try it and give us your feedback." I think I'd actually prefer Roman's suggestion. On Mon, Jan 6, 2020 at 8:55 AM R