Druid PR review checklist

2018-11-12 Thread Roman Leventov
A lot of new committers are expected to enter the projects with rights to review and merge PRs. I suggest to create a PR review checklist to help new (and old!) reviewers (and PR authors, for self-review before even publishing a PR) not to forget something. I think a PR (because it's not editable

Re: Druid PR review checklist

2018-11-13 Thread Julian Hyde
Thanks for starting this thread, Roman. It’s a great discussion to be having. A word of caution about google docs. Since this one can be edited by anyone who has the link, and the link is posted in a public archive, then at some point this doc will fall victim to spam or vandalism. I suggest tha

Re: Druid PR review checklist

2018-11-13 Thread Roman Leventov
Yes, definitely, that is what I was planning to do. Except that I would say that it could take closer to a month to complete a document. On Tue, 13 Nov 2018, 18:56 Julian Hyde Thanks for starting this thread, Roman. It’s a great discussion to be > having. > > A word of caution about google docs.

Re: Druid PR review checklist

2018-11-13 Thread Slim Bouguerra
Great Doc. Since the end goal is a .md document as part of the github repo. How about you actually start a PR and with something like mark down document and peoples can interact with it via git comments, that will be better than google Docs thought. On Tue, Nov 13, 2018 at 10:25 AM Roman Leventov

Re: Druid PR review checklist

2018-11-13 Thread Roman Leventov
I don't think that would be convenient. I don't want to act as a gatekeeper for every change and contribution to the doc. On Tue, 13 Nov 2018, 19:34 Slim Bouguerra Great Doc. > Since the end goal is a .md document as part of the github repo. How about > you actually start a PR and with something