Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-03-21 Thread Karan Kumar
Hi Vote thread for druid 29.0.1 is up. https://lists.apache.org/thread/6syof9fmnb7vbyjrpowrt7s73rh2bqy4 Thanks Karan On Wed, Feb 21, 2024 at 1:10 AM Vadim Ogievetsky wrote: > That sounds great to me. Thank you +1 > > On 2024/02/20 18:58:35 Laksh Singla wrote: > > Since the artifacts were alread

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-20 Thread Vadim Ogievetsky
That sounds great to me. Thank you +1 On 2024/02/20 18:58:35 Laksh Singla wrote: > Since the artifacts were already out at the time of the Vad's vote, I will > be going ahead with the release of Druid 29.0.0. However, I do echo with > the comments mentioned in the mail, therefore we can take the f

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-20 Thread Laksh Singla
Since the artifacts were already out at the time of the Vad's vote, I will be going ahead with the release of Druid 29.0.0. However, I do echo with the comments mentioned in the mail, therefore we can take the following steps to prevent misfortune for the unexpecting users: For the current Druid 2

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-19 Thread Abhishek Agarwal
Vad, The vote was closed by Laksh, given that 72 hours had passed and artifacts had been released. Given we had the three binding +1s, we can proceed as usual. I suggest that we call out the caveat clearly in the release notes section. On Mon, Feb 19, 2024 at 11:53 PM Vadim Ogievetsky wrote: > T

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-19 Thread Vadim Ogievetsky
Thank you for all the work getting this release to this point. As the author of https://github.com/apache/druid/pull/15588 I regretfully vote -1 on this release. To echo Gian's point I think the chance of some user injuring a production Datasource with an innocent query pasted into the wrong web

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-16 Thread Gian Merlino
Here's a patch with the validation idea: https://github.com/apache/druid/pull/15920 It adds validation for the most problematic case (mixing strings and arrays), provides a way to override the validation, and makes the warning log on the controller task when arrayIngestMode is 'mvd' more friend

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-16 Thread Gian Merlino
I just learned that arrayIngestMode is not actually new, just https://github.com/apache/druid/pull/15588 is. However this will still make it more likely that people accidentally break their tables, so I am still -0. Just, slightly less so. I still think it would be a good idea, for Druid 29, to add

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-16 Thread Gian Merlino
Thanks for managing this release! My vote is -0, let me explain why. I am concerned about usability issues with the new arrayIngestMode feature. There are various issues when mixing MVD strings and string arrays in the same column: as soon as arrays show up in a column, various "classic MVD-style"

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-15 Thread Karan Kumar
+1 (binding) src package: - verified checksum and signature - LICENSE and NOTICE present - built binary distribution, ran MSQ quickstart binary package: - verified checksum and signature - LICENSE and NOTICE present - ran MSQ quickstart docker: - verified checksum On Thu, Feb 15, 2024 at 5:41 A

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-14 Thread Clint Wylie
+1 (binding) src package: - verified checksum and signature - LICENSE and NOTICE present - rat check passed - built binary distribution, ran MSQ ingestion, ran some queries binary package: - verified checksum and signature - LICENSE and NOTICE present - ran native ingestion, ran some queries doc

Re: [VOTE] Release Apache Druid 29.0.0 [RC1]

2024-02-14 Thread Kashif Faraz
+1 (binding) src package: - verified checksum and signature - checked for LICENSE and NOTICE - rat check passed - built binary distribution - ingested sample wikipedia dataset, ran some queries, reindexed with range partitioning binary package: - verified checksum and signature - ingested sample