Re: A question about Druid design

2018-05-30 Thread Gian Merlino
Hi Anastasia, 1) At ingestion time the FactsHolder is sorted. The unsorted code path is used by groupBy v1, which hasn't been common since groupBy v2 was made the default a few releases ago. So I would only worry about the sorted case. 2) PlainFactsHolder is used when the user has disabled rollup

Re: A question about Druid design

2018-05-31 Thread Anastasia Braginsky
Hi Gian, Thanks for the explanations! I have one more question: You say that "...the RollupFactsHolder there will be a _single_ fact row per TimeAndDims... But with the PlainFactsHolder there may be more than one fact row per TimeAndDims..."In PlainFactsHolder we have more than one fact row p

Re: A question about Druid design

2018-06-13 Thread Anastasia Braginsky
Hi Everyone, Could I, please, call for your attention?The Oak project is on, and I would like to join the next weekly video meeting to present our progress.However, we are still in doubt regarding Rollup- vs Plain- FactsHolder. Could someone please read the email chain bellow and help with some

Re: A question about Druid design

2018-06-19 Thread Gian Merlino
Hi Anastasia, Sorry for the delay in getting back to you. You're right that the PlainFactsHolder is indexed by timestamp, not by TimeAndDims -- earlier I was answering from memory and not from actually looking at the code! Shows what I get for doing that. The idea with RollupFactsHolder is that a

Re: A question about Druid design

2018-06-19 Thread Anastasia Braginsky
Thank you Gian! Hope to see you later today in the meetingĀ  Sent from Yahoo Mail on Android On Tue, Jun 19, 2018 at 18:55, Gian Merlino wrote: Hi Anastasia, Sorry for the delay in getting back to you. You're right that the PlainFactsHolder is indexed by timestamp, not by TimeAndDims -- ea