[GitHub] vangoleo commented on issue #1501: local mock not work according by the user manual

2018-04-09 Thread GitBox
vangoleo commented on issue #1501: local mock not work according by the user manual URL: https://github.com/apache/incubator-dubbo/issues/1501#issuecomment-379654105 @diecui1202 Finished. This is an automated message from th

[GitHub] ralf0131 commented on issue #1501: local mock not work according by the user manual

2018-04-09 Thread GitBox
ralf0131 commented on issue #1501: local mock not work according by the user manual URL: https://github.com/apache/incubator-dubbo/issues/1501#issuecomment-379654948 This has been fixed by https://github.com/apache/incubator-dubbo-docs/pull/12 -

[GitHub] ralf0131 closed issue #1501: local mock not work according by the user manual

2018-04-09 Thread GitBox
ralf0131 closed issue #1501: local mock not work according by the user manual URL: https://github.com/apache/incubator-dubbo/issues/1501 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] proaway commented on issue #1012: Wanted: who's using dubbo

2018-04-09 Thread GitBox
proaway commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379622902 公司:银湖网络科技有限公司 地址:中国北京 联系方式: proa...@qq.com 场景:共享服务体系架构 This is an automate

[GitHub] nzomkxia commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type

2018-04-09 Thread GitBox
nzomkxia commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type URL: https://github.com/apache/incubator-dubbo/pull/1456#discussion_r180007828 ## File path: dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/extension/

[GitHub] carryxyh commented on a change in pull request #1568: Extension: Enhanced Thread Pool

2018-04-09 Thread GitBox
carryxyh commented on a change in pull request #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#discussion_r180008545 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/enhanced/EnhancedThreadPoolExecu

[GitHub] leyou240 commented on issue #1553: add missing @Override to classes

2018-04-09 Thread GitBox
leyou240 commented on issue #1553: add missing @Override to classes URL: https://github.com/apache/incubator-dubbo/pull/1553#issuecomment-379661581 aim to #1239 This is an automated message from the Apache Git Service. To re

[GitHub] carryxyh commented on a change in pull request #1568: Extension: Enhanced Thread Pool

2018-04-09 Thread GitBox
carryxyh commented on a change in pull request #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#discussion_r180009020 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/enhanced/EnhancedTaskQueue.java

[GitHub] VanXD commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突

2018-04-09 Thread GitBox
VanXD commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突 URL: https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379671041 @tangdu is there any way use java config?there nothing about qos, did i miss something? ![image](https://user-images.githubuser

[GitHub] mzorro opened a new pull request #1573: Method extraction & Unnecessary code remove & Typo fix

2018-04-09 Thread GitBox
mzorro opened a new pull request #1573: Method extraction & Unnecessary code remove & Typo fix URL: https://github.com/apache/incubator-dubbo/pull/1573 - Break old "loadFile" into pieces, improve readability. - Remove some unnecessary code. - Some typo fix. In conclusion, this

[GitHub] wanhuhou opened a new pull request #1574: circuitBreaker

2018-04-09 Thread GitBox
wanhuhou opened a new pull request #1574: circuitBreaker URL: https://github.com/apache/incubator-dubbo/pull/1574 ## What is the purpose of the change Add CircuitBreaker This is an automated message from the Apache

[GitHub] codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix

2018-04-09 Thread GitBox
codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix URL: https://github.com/apache/incubator-dubbo/pull/1573#issuecomment-379682150 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=h1) Report > Merging [#1573](https:/

[GitHub] codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix

2018-04-09 Thread GitBox
codecov-io commented on issue #1573: Method extraction & Unnecessary code remove & Typo fix URL: https://github.com/apache/incubator-dubbo/pull/1573#issuecomment-379682150 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1573?src=pr&el=h1) Report > Merging [#1573](https:/

[GitHub] codecov-io commented on issue #1568: Extension: Enhanced Thread Pool

2018-04-09 Thread GitBox
codecov-io commented on issue #1568: Extension: Enhanced Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379553497 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=h1) Report > Merging [#1568](https://codecov.io/gh/apache/in

[GitHub] ralf0131 commented on issue #1574: circuitBreaker

2018-04-09 Thread GitBox
ralf0131 commented on issue #1574: circuitBreaker URL: https://github.com/apache/incubator-dubbo/pull/1574#issuecomment-379685516 1. The CI has failed. 2. This is a significant change, you need to sign the SGA before merging.

[GitHub] iamybj commented on issue #1012: Wanted: who's using dubbo

2018-04-09 Thread GitBox
iamybj commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379691513 熊样,都是一群小鸡巴公司。 阿里所谓的开源,就是为了KPI和名声,把人家外国公司早就开源的程序,拿过来自己改改,然后新起一个名字,释放出去沽名钓誉。 这和它妈的中国某些部门,把人家外国的东西拿来打磨掉LOGO,然后把自己的LOGO印上去,就说是自主知识产权有什么区别?

[GitHub] iamybj commented on issue #1012: Wanted: who's using dubbo

2018-04-09 Thread GitBox
iamybj commented on issue #1012: Wanted: who's using dubbo URL: https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379691513 熊样,都是一群小鸡巴公司。 阿里所谓的开源,就是为了KPI和名声,把人家外国公司早就开源的程序,拿过来自己改改,然后新起一个名字,释放出去沽名钓誉。 这和它妈的中国某些部门,把人家外国的东西拿来打磨掉LOGO,然后把自己的LOGO印上去,就说是自主知识产权有什么区别?

[GitHub] wzlee commented on issue #1571: Is there any deadline to release a version?

2018-04-09 Thread GitBox
wzlee commented on issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379694174 @litttlefisher https://github.com/apache/incubator-dubbo-spring-boot-project --

[GitHub] hengyunabc commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突

2018-04-09 Thread GitBox
hengyunabc commented on issue #1545: 怎样禁用qos-server,因为我是spark项目,一台服务器会启动多个,导致端口冲突 URL: https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379694617 @VanXD https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.1/dubbo-plugin/dubbo-qos/src/main/java/com/alibaba/dubbo/qos/

[GitHub] litttlefisher commented on issue #1571: Is there any deadline to release a version?

2018-04-09 Thread GitBox
litttlefisher commented on issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379699560 [issue91](https://github.com/apache/incubator-dubbo-spring-boot-project/issues/91) It's said that dubbo-spring-boot is w

[GitHub] codecov-io commented on issue #1574: circuitBreaker

2018-04-09 Thread GitBox
codecov-io commented on issue #1574: circuitBreaker URL: https://github.com/apache/incubator-dubbo/pull/1574#issuecomment-379704926 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1574?src=pr&el=h1) Report > Merging [#1574](https://codecov.io/gh/apache/incubator-dubbo/pul

[GitHub] htynkn opened a new pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
htynkn opened a new pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575 ## What is the purpose of the change add java9 in ci ## Brief changelog use jacoco fix reflection issue ## Verifying this change ci pass

[GitHub] codecov-io commented on issue #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
codecov-io commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379710354 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1575?src=pr&el=h1) Report > Merging [#1575](https://codecov.io/gh/apac

[GitHub] neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0?

2018-04-09 Thread GitBox
neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379713035 @suclogger I know it's quite annoying, but do you have any idea that once any changes applied to the working simple,

[GitHub] beiwei30 closed pull request #1572: remove the method with the same function but the different name in Ne…

2018-04-09 Thread GitBox
beiwei30 closed pull request #1572: remove the method with the same function but the different name in Ne… URL: https://github.com/apache/incubator-dubbo/pull/1572 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] kimmking commented on issue #1571: Is there any deadline to release a version?

2018-04-09 Thread GitBox
kimmking commented on issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379726363 @mercyblitz This is an automated message from the Apache Git Se

[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180072273 ## File path: pom.xml ## @@ -422,16 +421,27 @@ -

[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180072273 ## File path: pom.xml ## @@ -422,16 +421,27 @@ -

[GitHub] kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
kimmking commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180072273 ## File path: pom.xml ## @@ -422,16 +421,27 @@ -

[GitHub] codecov-io commented on issue #1568: Extension: Eager Thread Pool

2018-04-09 Thread GitBox
codecov-io commented on issue #1568: Extension: Eager Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568#issuecomment-379553497 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1568?src=pr&el=h1) Report > Merging [#1568](https://codecov.io/gh/apache/incub

[GitH b] htynkn commented on a change in p ll req est #1575: [d bbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
htynkn commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180079840 ## File path: pom.xml ## @@ -422,16 +421,27 @@ -

[GitH b] lovepoem commented on iss e #1575: [d bbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379780830 When you have tested the program error or the test case doesn't pass, will the CI process terminate? @htynkn ---

[GitH b] lovepoem commented on iss e #1575: [d bbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379780830 Have tested when the program error or the test case doesn't pass, will the CI process terminate? @htynkn

[GitH b] lovepoem commented on iss e #1575: [d bbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379780830 Have you tested when the program error or the test case doesn't pass, will the CI process terminate? @htynkn

[GitHub] beiwei30 closed pull request #1568: Extension: Eager Thread Pool

2018-04-09 Thread GitBox
beiwei30 closed pull request #1568: Extension: Eager Thread Pool URL: https://github.com/apache/incubator-dubbo/pull/1568 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[GitHub] beiwei30 commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

2018-04-09 Thread GitBox
beiwei30 commented on a change in pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r180152425 ## File path: dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMo

[GitHub] suclogger commented on issue #93: Is it incompatible with Spring Boot 2.0?

2018-04-09 Thread GitBox
suclogger commented on issue #93: Is it incompatible with Spring Boot 2.0? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379813389 @neesonqk As far as I can see, maybe you didn't start provider before your try to consume? ---

[GitHub] zonghaishang commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type

2018-04-09 Thread GitBox
zonghaishang commented on a change in pull request #1456: [Dubbo-SPI] Spring spi support inject by type URL: https://github.com/apache/incubator-dubbo/pull/1456#discussion_r180157548 ## File path: dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/extens

[GitHub] neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0?

2018-04-09 Thread GitBox
neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0? URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-379833720 @suclogger I'm very sure that I've started the provider ahead of the consumer. I'll try to reproduce the same proble

[GitHub] htynkn commented on issue #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
htynkn commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379938704 @lovepoem please refer this build: https://travis-ci.org/diamondblack/incubator-dubbo If test fail, CI will fail too. logs here: https://

[GitHub] chickenlj opened a new issue #101: Better use the newest dubbo 2.6.x version and only depend on necessary modules.

2018-04-09 Thread GitBox
chickenlj opened a new issue #101: Better use the newest dubbo 2.6.x version and only depend on necessary modules. URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/101 1. use the newest 2.6.x dubbo version 2. Depend on necessary modules instead of a fat jar. F

[GitHub] lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
lovepoem commented on issue #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#issuecomment-379944759 Look good to me This is an automated message from the Apache Git Service.

[GitHub] levin950825 opened a new issue #1576: When to publish the next release

2018-04-09 Thread GitBox
levin950825 opened a new issue #1576: When to publish the next release URL: https://github.com/apache/incubator-dubbo/issues/1576 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] beiwei30 closed issue #1510: dubbo monitor missing parameters

2018-04-09 Thread GitBox
beiwei30 closed issue #1510: dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/issues/1510 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] beiwei30 closed pull request #1407: [Dubbo-1510] dubbo monitor missing parameters

2018-04-09 Thread GitBox
beiwei30 closed pull request #1407: [Dubbo-1510] dubbo monitor missing parameters URL: https://github.com/apache/incubator-dubbo/pull/1407 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[GitHub] cnhaicao commented on issue #1523: dubbo多分支api依赖版本管理问题

2018-04-09 Thread GitBox
cnhaicao commented on issue #1523: dubbo多分支api依赖版本管理问题 URL: https://github.com/apache/incubator-dubbo/issues/1523#issuecomment-379956932 Dubbo multi-branch api dependent version management issues According to the official recommendation, the public api project is extracted betwe

Re: Is Spring Optional?

2018-04-09 Thread Ian Luo
John, If you want to adapt dubbo into other DI framework, then you need to wire dubbo config API into this DI framework. I suggest you look into dubbo-config-api and dubbo-config-spring under https://github.com/apache/incubator-dubbo/tree/master/dubbo-config to understand how we integrate spring f

[GitHub] beiwei30 commented on issue #1548: Where can I get the startup script for Dubbo

2018-04-09 Thread GitBox
beiwei30 commented on issue #1548: Where can I get the startup script for Dubbo URL: https://github.com/apache/incubator-dubbo/issues/1548#issuecomment-379959237 There's no start.sh provided for dubbo application since the script varies depending on how you develop and deploy your dubbo pr

[GitHub] beiwei30 closed issue #1548: Where can I get the startup script for Dubbo

2018-04-09 Thread GitBox
beiwei30 closed issue #1548: Where can I get the startup script for Dubbo URL: https://github.com/apache/incubator-dubbo/issues/1548 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] beiwei30 closed issue #1545: how to disable qos

2018-04-09 Thread GitBox
beiwei30 closed issue #1545: how to disable qos URL: https://github.com/apache/incubator-dubbo/issues/1545 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] beiwei30 commented on issue #1545: how to disable qos

2018-04-09 Thread GitBox
beiwei30 commented on issue #1545: how to disable qos URL: https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379960046 @VanXD https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.1/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ApplicationConfig.j

[GitHub] ralf0131 commented on issue #1574: circuitBreaker

2018-04-09 Thread GitBox
ralf0131 commented on issue #1574: circuitBreaker URL: https://github.com/apache/incubator-dubbo/pull/1574#issuecomment-379685516 1. The CI has failed. 2. This is a significant change, you need to sign the SGA[1] before merging. [1] https://www.apache.org/licenses/#grants --

[GitHub] diecui1202 commented on issue #1500: not support java 10

2018-04-09 Thread GitBox
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379962207 @hank-whu I run this two server/client demo on my mac, and it's all ok. ![image](https://user-images.githubusercontent.com/1152291/38534599-889

[GitHub] diecui1202 commented on issue #1500: not support java 10

2018-04-09 Thread GitBox
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379962207 @hank-whu I run this two server/client demo with Dubbo 2.6.1 on my mac, and it's all ok. ![image](https://user-images.githubusercontent.com/11

[GitHub] ralf0131 commented on issue #1576: When to publish the next release

2018-04-09 Thread GitBox
ralf0131 commented on issue #1576: When to publish the next release URL: https://github.com/apache/incubator-dubbo/issues/1576#issuecomment-379962808 Hi, we are going to discuss the release schedule in the mailing list this week. Please [subscribe](https://github.com/apache/incubator-dubbo

[GitHub] ralf0131 closed issue #1576: When to publish the next release

2018-04-09 Thread GitBox
ralf0131 closed issue #1576: When to publish the next release URL: https://github.com/apache/incubator-dubbo/issues/1576 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] ralf0131 closed issue #1571: Is there any deadline to release a version?

2018-04-09 Thread GitBox
ralf0131 closed issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] ralf0131 commented on issue #1571: Is there any deadline to release a version?

2018-04-09 Thread GitBox
ralf0131 commented on issue #1571: Is there any deadline to release a version? URL: https://github.com/apache/incubator-dubbo/issues/1571#issuecomment-379962924 Hi, we are going to discuss the release schedule in the mailing list this week. Please [subscribe](https://github.com/apache/incu

[GitHub] ralf0131 commented on issue #1500: not support java 10

2018-04-09 Thread GitBox
ralf0131 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379964569 @diecui1202 Please use text instead of pic as much as possible. Text is more search engine friendly. ---

[GitHub] ralf0131 commented on issue #1500: not support java 10

2018-04-09 Thread GitBox
ralf0131 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379964708 Looks like this issue is not reproducible, I am closing this issue now. Feel free to reopen it if you can reproduce it later. -

[GitHub] ralf0131 closed issue #1500: not support java 10

2018-04-09 Thread GitBox
ralf0131 closed issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] fuyongde opened a new issue #102: Warning of `com.alibaba.boot.dubbo.autoconfigure.DubboAutoConfiguration`

2018-04-09 Thread GitBox
fuyongde opened a new issue #102: Warning of `com.alibaba.boot.dubbo.autoconfigure.DubboAutoConfiguration` URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/102 It warned `Cannot enhance @Configuration bean definition 'com.alibaba.boot.dubbo.autoconfigure.DubboAutoC

[GitHub] lovepoem closed pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
lovepoem closed pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreig

[GitHub] lovepoem closed issue #1521: Add java9 in CI build

2018-04-09 Thread GitBox
lovepoem closed issue #1521: Add java9 in CI build URL: https://github.com/apache/incubator-dubbo/issues/1521 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180290615 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java ## @@ -910,6

[GitHub] lovepoem commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
lovepoem commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180290674 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java ## @@ -910,6

[GitHub] fuyongde opened a new pull request #103: fix issues #102

2018-04-09 Thread GitBox
fuyongde opened a new pull request #103: fix issues #102 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/103 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] htynkn commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
htynkn commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180294062 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java ## @@ -910,6 +

[GitHub] lkj41110 opened a new pull request #1577: a

2018-04-09 Thread GitBox
lkj41110 opened a new pull request #1577: a URL: https://github.com/apache/incubator-dubbo/pull/1577 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your cont

[GitHub] hank-whu commented on issue #1500: not support java 10

2018-04-09 Thread GitBox
hank-whu commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379978154 @diecui1202 现在那两个项目 pom.xml 里的 dubbo 版本是 2.6.0,你把里面的版本修改为 2.6.1 了吗? This is an a

[GitHub] diecui1202 commented on issue #1500: not support java 10

2018-04-09 Thread GitBox
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379978352 @hank-whu Yeah, I've changed it to 2.6.1 yet. @ralf0131 Ok, I got it. This is a

[GitHub] beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml

2018-04-09 Thread GitBox
beiwei30 commented on a change in pull request #1575: [dubbo-1521]add java 9 in travis yml URL: https://github.com/apache/incubator-dubbo/pull/1575#discussion_r180301153 ## File path: dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java ## @@ -910,6

[GitHub] mercyblitz closed issue #1536: zookeeper 提供者问题?

2018-04-09 Thread GitBox
mercyblitz closed issue #1536: zookeeper 提供者问题? URL: https://github.com/apache/incubator-dubbo/issues/1536 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] diecui1202 commented on issue #1539: 使用 mock 时,使用 warn 级别无法打印调用生产者异常堆栈

2018-04-09 Thread GitBox
diecui1202 commented on issue #1539: 使用 mock 时,使用 warn 级别无法打印调用生产者异常堆栈 URL: https://github.com/apache/incubator-dubbo/issues/1539#issuecomment-379981153 I think it's a mistake. I'll fix it today. This is an automated message

[GitHub] hank-whu commented on issue #1500: not support java 10

2018-04-09 Thread GitBox
hank-whu commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379981373 @diecui1202 我试了很多次,还是不行,你的 pom 文件可以贴上来吗? This is an automated message from the Apach

[GitHub] diecui1202 commented on issue #1500: not support java 10

2018-04-09 Thread GitBox
diecui1202 commented on issue #1500: not support java 10 URL: https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379981687 ``` http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/P

[Suggestion] PR failing if test coverage went down

2018-04-09 Thread htynkn
hey team, In pull request template(https://github.com/apache/incubator-dubbo/blob/master/PULL_REQUEST_TEMPLATE.md), this is one item to ask all pr to "Write necessary unit-test to verify your logic correction" Codecov has feature to fail PR if test coverage went down. Which means for an

Re: [Suggestion] PR failing if test coverage went down

2018-04-09 Thread Huxing Zhang
Hi, Thanks for the suggestion. I generally agree with the idea that we should prevent a pull request to be merged if the code coverage gets lower. But my concern is the code coverage might have a minor drop even when just fixing typo[1], which makes confused. Unless we can figure it out, or I t