[DISCUSS] should we include gson support in main trunk

2018-10-29 Thread Ian Luo
Hi folks, Today I noticed there's one pull request 2699 (dubbo Add a new serialization -gson) [1] pending for review. I'm hesitate to move it in since we've already had fastjson serialization support which serves the same purpose. I'd like to hear your opinion on this. Thanks, -Ian. 1. https:/

[Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread victory
Hello Community, As 2.6.4 has been released, I think we are ready for the next maintenance release 2.6.5 now. In this release, we plan to solve the issues and requirements reported by the community recently: Enhancements / Features: - [#2655](https://github.com/apache/incubator-dubbo/issues/26

Re:[Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread 秦金卫
there is an important enhancement: https://github.com/apache/incubator-dubbo/pull/2647 ? At 2018-10-29 19:47:30, "victory" wrote: >Hello Community, > > >As 2.6.4 has been released, I think we are ready for the next maintenance >release 2.6.5 now. In this release, we plan to solve the issues and

Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread victory
Ok, I left out some issues in the one week. All issues are from https://github.com/apache/incubator-dubbo/issues/2663 I will check again, and all of you can let me know if I left out something. 秦金卫 于2018年10月29日周一 下午11:04写道: > there is an important enhancement: > https://github.com/apache/incuba

Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread Jerrick Zhu
You could use git log on 2.6.x branch, and check all the commits after 2.6.4. On Tue, Oct 30, 2018 at 10:02 AM victory wrote: > Ok, I left out some issues in the one week. All issues are from > https://github.com/apache/incubator-dubbo/issues/2663 > I will check again, and all of you can let me

Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread Ian Luo
+1, we should mention this. Victory, would you mind to iterate all changes since release 2.6.4 to make sure nothing is missing in the release note? Thanks, -Ian. On Mon, Oct 29, 2018 at 11:04 PM 秦金卫 wrote: > there is an important enhancement: > https://github.com/apache/incubator-dubbo/pull/26

[ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread Jun Liu
Hi, Community, On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma, whose github id is majinkai, has been voted in as a new Dubbo committer. Please join me to say congratulations to him! Jinkai, would you please briefly introduce yourself to the community? Best regards, Jun

Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread Jun Liu
> On Oct 30, 2018, at 11:12 AM, Jun Liu wrote: > > Hi, Community, > > On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma, whose > github id is majinkai, has been voted in as a new Dubbo committer. > > Please join me to say congratulations to him! > > Jinkai, would you ple

Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread Ian Luo
Congratulations! welcome to the community :) On Tue, Oct 30, 2018 at 11:15 AM Jun Liu wrote: > > > > On Oct 30, 2018, at 11:12 AM, Jun Liu wrote: > > > > Hi, Community, > > > > On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma, > whose github id is majinkai, has been voted in

pull request 2686

2018-10-29 Thread Ian Luo
Xiaobo, Would you mind to take a look at the comments I dropped on pull request 2686 [1] you proposed? Basically I think we could completely remove isDelay method, if you agree with this idea, pls. follow up to enhance your pull request. Thanks, -Ian. 1. https://github.com/apache/incubator-dubbo

Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread yuhang xiu
Hi, jinkai Congratulations on your joining! Jun Liu 于2018年10月30日周二 上午11:15写道: > > > > On Oct 30, 2018, at 11:12 AM, Jun Liu wrote: > > > > Hi, Community, > > > > On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma, > whose github id is majinkai, has been voted in as a new Dubbo

Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread Jerrick Zhu
congrats, majinkai. On Tue, Oct 30, 2018 at 11:17 AM Ian Luo wrote: > Congratulations! welcome to the community :) > > On Tue, Oct 30, 2018 at 11:15 AM Jun Liu wrote: > > > > > > > > On Oct 30, 2018, at 11:12 AM, Jun Liu wrote: > > > > > > Hi, Community, > > > > > > On behalf of the Dubbo PPM

回复:[ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread 马金凯
Hi, all, It's my great honor to join the dubbo family, my name Jinkai Ma, and work at Handuyishe. I started using dubbo five years ago, and i like to participate in the open source community, it's very helpful to me. Hope the dubbo and apache communities gets better, best wish for eve

Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread Xin Wang
Congratulations,Jinkai 马金凯 于2018年10月30日周二 上午11:29写道: > Hi, all, > It's my great honor to join the dubbo family, my name Jinkai Ma, and > work at Handuyishe. > I started using dubbo five years ago, and i like to participate in the > open source community, it's very helpful to me. > Ho

Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread YunKun Huang
Congratulations ! On 2018/10/30 03:20:58, yuhang xiu wrote: > Hi, jinkai > Congratulations on your joining! > > Jun Liu 于2018年10月30日周二 上午11:15写道: > > > > > > > > On Oct 30, 2018, at 11:12 AM, Jun Liu wrote: > > > > > > Hi, Community, > > > > > > On behalf of the Dubbo PPMC, I am pleased to a

Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread victory
I have checked again, and modify the release note here: https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md . You can also check it as follow: Enhancements / Features: - @Service and @Reference Optimization #2655 #2

Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread Jerrick Zhu
Great. Lots of enhancements and bugfixes. On Tue, Oct 30, 2018 at 2:22 PM victory wrote: > I have checked again, and modify the release note here: > https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md . > You can also check it as follow: > > Enhancements / Features: > >-