Re: [DISCUSS] Branch strategy for dubbo-website

2019-06-18 Thread Huxing Zhang
Nice! Maybe should be add some link to our website. On Tue, Jun 18, 2019 at 12:13 PM YunKun Huang wrote: > > thanks for advice. I rebuild api doc with new path. (refer to link [1] [2]) > > And for item 2, item 3, because 2.7.2 already released, some improvement can > be done in next version. I

Re: [DISCUSS] Dubbo release versioning

2019-06-18 Thread Justin Mclean
Hi, I’d be careful of using the term RC (release candidate) as that has a particular meaning at Apache. i.e a pre-release put up for vote by the PMC for consideration of making it a release. Once released I’d not call it a release candidate. Thanks, Justin

Re: [DISCUSS] How to automatically format the license header of the source file

2019-06-18 Thread slievrly
In the past, I tried to add a license header using apache rat, but some problems have occurred. I have discussed with Philipp Ottlinger on these issues. ref: https://issues.apache.org/jira/browse/RAT-255 Current problems: 1. The maven plugin of apache rat automatically adds the license header.

Re: [DISCUSS] How to automatically format the license header of the source file

2019-06-18 Thread Justin Mclean
Hi, > 3. When setting copyrightMsg, it cannot format in the given format. There should be no copyright message in ASF headers. > 4. When using the apache rat command line, it was found that it could not be > run. I’ve used successfully in the past, what issues did you run into? They may be ab

Re: [DISCUSS] Dubbo release versioning

2019-06-18 Thread Huxing Zhang
Hi, On Wed, Jun 19, 2019 at 11:57 AM Justin Mclean wrote: > > Hi, > > I’d be careful of using the term RC (release candidate) as that has a > particular meaning at Apache. i.e a pre-release put up for vote by the PMC > for consideration of making it a release. Once released I’d not call it a >

Re: [DISCUSS] How to automatically format the license header of the source file

2019-06-18 Thread slievrly
Hi, 3. Here we don't have to set a header, it can be generated automatically. But it is automatically generated inconsistent with the location of our current existing header and the broken line words for each line. We want a fixed header, so we need to consider setting the copyrightMessage pro

Re: [DISCUSS] Dubbo release versioning

2019-06-18 Thread Justin Mclean
Hi, > Yes, to avoid possible conflict, it can be changed to another term like > alpha, beta, or milestone? Sounds fine to me. To not do so might cause some confusion. Thanks, Justin