Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Justin Mclean
Hi, > You need to fix the license header issue Justin points out. Well my question also needs to be answered is it just a missing header (a minor issues) or is it 3rd party software (a more serious issue). Thanks, Justin

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Ian Luo
Stocks Alex, You need to fix the license header issue Justin points out: 1. dubbo-go-1.1.0/cluster/loadbalance/round_robin_test.go > 2. dubbo-go-1.1.0/common/extension/router_factory.go > 3. dubbo-go-1.1.0/config_center/configuration_parser.go > 4. dubbo-go-1.1.0/config_center/configuration_parse

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Justin Mclean
Hi, I’m still seeing a lot of +1’s without saying what was checked, if you vote please list what you checked as it helps other people know where to look. If also expected that people will compile and test it and report back if there are any issues outside of what’s the ASF requires for a releas

Re: Dubbo as OSGi Remote Service Distribution

2019-09-05 Thread Jun Liu
Thanks Scott. Thanks for the detailed explanation, it really helps me and I think also the community a lot. Sorry for coming back late, but I am really busy with some other things on hand recently. I personally think OSGIRegistry can be a good choice to enrich the Dubbo ecosystem. I would recom

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread 张海彬
verify release candidate +1 Stocks Alex 于2019年9月4日周三 下午8:17写道: > Hello Dubbo/Dubbogo Community, > > This is a call for vote to release Apache Dubbo-go version v1.1.0. > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/ > Git tag for the release: > https:/

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Xinge Gao
+1 Stocks Alex 于2019年9月4日周三 下午8:17写道: > Hello Dubbo/Dubbogo Community, > > This is a call for vote to release Apache Dubbo-go version v1.1.0. > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/ > Git tag for the release: > https://github.com/apache/dubbo-

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Justin Mclean
Hi, Great improvement over the previous release but there are still issues from the last vote that have not been resolved. e.g. [6][7][8] Can someone tell me if these files [1][2][3][4][5] are just missing ASF headers or have a different license? If they are just missing headers and [6][7][8]

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Ian Luo
Guys, you need to follow 'verify release candidate'[1] to vote an apache release. Thanks, -Ian. 1. http://dubbo.apache.org/zh-cn/docs/developers/committer-guide/release-guide_dev.html On Thu, Sep 5, 2019 at 10:06 PM xinming he wrote: > +1 > > kimm king 于2019年9月5日周四 下午10:04写道: > > > [v] +1 rel

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread xinming he
+1 kimm king 于2019年9月5日周四 下午10:04写道: > [v] +1 release the software > > Shunyu Lei 于2019年9月5日周四 下午9:38写道: > > > +1 > > > > Ian Luo 于2019年9月5日周四 下午9:25写道: > > > > > +1 to approve. I checked the items below: > > > > > > > > > [v] Are release files in correct location? > > > > > > [v] Are the dig

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread kimm king
[v] +1 release the software Shunyu Lei 于2019年9月5日周四 下午9:38写道: > +1 > > Ian Luo 于2019年9月5日周四 下午9:25写道: > > > +1 to approve. I checked the items below: > > > > > > [v] Are release files in correct location? > > > > [v] Are the digital signature and hashes correct? > > > > [v] Do LICENSE and NOTI

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Shunyu Lei
+1 Ian Luo 于2019年9月5日周四 下午9:25写道: > +1 to approve. I checked the items below: > > > [v] Are release files in correct location? > > [v] Are the digital signature and hashes correct? > > [v] Do LICENSE and NOTICE files exists? > > [v] Is the LICENSE and NOTICE text correct? > > [v] Is the NOTICE

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Ian Luo
+1 to approve. I checked the items below: [v] Are release files in correct location? [v] Are the digital signature and hashes correct? [v] Do LICENSE and NOTICE files exists? [v] Is the LICENSE and NOTICE text correct? [v] Is the NOTICE year correct? [v] Un-included software dependencies ar

Re: pull request 4899

2019-09-05 Thread Ian Luo
Thanks, then I will proceed. On Thu, Sep 5, 2019 at 5:40 PM 彭君健 wrote: > Thanks for the help, I have merged your change. > > Ian Luo 于2019年9月5日周四 下午5:32写道: > >> Hi Junjian, >> >> Hope you are doing well. Would you mind take a look at my review comment >> for pull request 4899. I send this messa

pull request 4899

2019-09-05 Thread Ian Luo
Hi Junjian, Hope you are doing well. Would you mind take a look at my review comment for pull request 4899. I send this message in case you didn't notice my comment on GitHub. Thanks, -Ian.