+1 binding
I checked:
* signatures and hashes are good
* LICENSE and NOTICE exit and content are good
* all source files no binary files
As Justin has pointed, some files do not have the right Apache License Header.
I am wondering if it’s possible for this project's building tool to add some
I took a moment to write a script to detect a license file for a nodejs
project
Jun Liu 于2019年12月23日周一 上午11:03写道：
> +1 binding
>
> I checked:
> * signatures and hashes are good
> * LICENSE and NOTICE exit and content are good
> * all source files no binary files
>
> As Justin has pointed, som
Hi,
Again I would strongly recommend that you not release this because of the
30MB of git internal files contained in the release.
Thanks,
Justin
On Mon, 23 Dec 2019, 14:07 胡锋, wrote:
> I took a moment to write a script to detect a license file for a nodejs
> project
>
> Jun Liu 于2019年12月23日周
I agree with Justin
let me fixed it and vote to release Apache dubbo-js version v3.0.0-rc3
Thanks,
hufeng
Justin Mclean 于2019年12月23日周一 上午11:30写道：
> Hi,
>
> Again I would strongly recommend that you not release this because of the
> 30MB of git internal files contained in the release.
>
> Than
Thanks you all for voting, but I am afraid we have to restart a new vote after
fixed the following issue relating to gRPC protocol support.
https://github.com/apache/dubbo/issues/5511
Jun
> On Dec 21, 2019, at 7:37 PM, YunKun Huang wrote:
>
> Hi,
>
> [x] +0 no opinion
>
> I have checked:
>
bugs
- fix: zkRegistry.Destroy() -- negative Waitgroup counter
https://github.com/apache/dubbo-go/pull/281
- https://github.com/apache/dubbo-go/pull/277
https://github.com/apache/dubbo-go/pull/277
features
- change the position of the lock
https://github.com/apache/dubbo-go/pul
