Hello, +1 binding.
I checked: - signature is ok - sha512 hash is ok - no binary fies - notice is ok however, I have two suggestions: - 1 u should not modify the 1.3.0 release notes in CHANGE.md. It will be better if u add 1.3.0-rc2 release notes into it. - 2 the contributing.md should have more programming advices. Justin Mclean <jus...@classsoftware.com> 于2020年2月12日周三 上午10:03写道： > Hi, > > +1 binding but there a minor issue mentioned before that was not fixed. > > I checked: > - signatures and hashes are OK > - The LICENSE imisisng mention of [1] > - NOTICE is correct > - all source files have ASF headers (except [1]) > - no unexpected binary files > - Again didn’t compile from source. The instruction on how to do this > could be clearer in the readme. > > Thanks, > Justin > > 1. ./protocol/grpc/protoc-gen-dubbo/examples/helloworld.proto
