+1 approve.
I checked:
- Signatures and hashes are good
- All unit tests can be passed
方银城 于2020年10月8日周四 下午7:07写道：
> +1 approve.
>
> I checked:
> - signatures are good
> - all uts passed
>
> stocks alex 于2020年10月8日周四 下午4:09写道：
>
> > +1 approve.
> >
> > I checked:
> > - sha512 hashes
+1 approve.
I checked:
- signatures are good
- all uts passed
stocks alex 于2020年10月8日周四 下午4:09写道：
> +1 approve.
>
> I checked:
> - sha512 hashes and signatures are good
> - all uts passed
>
> However, some improvements need to be made.
> 1 Pls check the second import block of common/pro
+1 approve
stocks alex 于2020年10月8日周四 下午5:36写道：
> I approve this suggestion now. because there is version branch in dubbo-go
> samples.
>
> YiXian Zou 于2020年10月7日周三 上午10:43写道：
>
> > Hi,
> > So sorry for late reply. because there is something wrong with my
> VPN,
> > In my option, i am n
I approve this suggestion now. because there is version branch in dubbo-go
samples.
YiXian Zou 于2020年10月7日周三 上午10:43写道：
> Hi,
> So sorry for late reply. because there is something wrong with my VPN,
> In my option, i am not suggest put samples or integration testing into
> dubbo-go[1].
>
+1 approve.
I checked:
- sha512 hashes and signatures are good
- all uts passed
However, some improvements need to be made.
1 Pls check the second import block of common/proxy/proxy_test.go and
improve it.
joezou 于2020年9月27日周日 上午9:45写道：
> Hello Dubbo/Dubbogo Community,
>
> This is a call
