Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1

2020-01-22 Thread 方银城
Thanks! We will solve these issues very well. A pr is https://github.com/apache/dubbo-go/pull/336 stocks alex 于2020年1月22日周三 下午4:59写道: > I vote +1 (binding) to this release. > > I checked the following conditions: > [v] Are the digital signature and hashes correct? > [v] Do LICENSE and NOTICE fil

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1

2020-01-22 Thread stocks alex
I vote +1 (binding) to this release. I checked the following conditions: [v] Are the digital signature and hashes correct? [v] Do LICENSE and NOTICE files exists? [x] Un-included software dependencies are not mentioned in LICENSE or NOTICE? [v] Do the contents of the release match with what's tagg

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1

2020-01-21 Thread victory
+1 binding I checked: - signatures and hashes are OK - all source files have ASF headers - run go test, and all tests passed. Ian Luo 于2020年1月22日周三 上午11:48写道: > I checked the following items. I vote +1 (binding) to this release. > > [v] Are release files in correct location? > [v] Are the digi

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1

2020-01-21 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release. [v] Are release files in correct location? [v] Are the digital signature and hashes correct? [v] Do LICENSE and NOTICE files exists? [v] Is the LICENSE and NOTICE text correct? [v] Is the NOTICE year correct? [x] Un-included soft

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1

2020-01-21 Thread Justin Mclean
Hi, +1 binding but there a couple of minor issue that need to be fixed before next release I checked: - signatures and hashes are OK - The LICENSE is missing the appendix and one copyright owner - the year in NOTICE is incorrect - all source files have ASF headers - no unexpected binary files -

[VOTE]: Release Apache dubbo-go v1.3.0 RC1

2020-01-18 Thread 方银城
Hello Dubbo/Dubbogo Community, This is a call for vote to release Apache dubbo-go version v1.3.0 RC1. The release candidates: https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc1/ Git tag for the release: https://github.com/apache/dubbo-go/tree/1.3.0 Hash for the release tag