[VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-06 Thread hufeng@apache
Hello Dubbo/Dubbojs Community, This is a call for vote to release Apache dubbo-js version v3.0.0-rc2. The release candidates: https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc2/ Git tag for the release: https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md Hash for the release t

[VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-18 Thread 胡锋
Hello Dubbo/Dubbojs Community, This is a call for vote to release Apache dubbo-js version v3.0.0-rc2. The release candidates: https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc2/ Git tag for the release: https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md Hash for the release t

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-07 Thread Justin Mclean
HI, Sorry but it’s -1 (binding) due to compile code in release [1][2] and file not have correct asf headers I checked: - Signatures and hashes fine - LICENSE and NOTICE are fine - Compiled code exist in the release [1][2] - Some java files are missing ASF headers e.g [3] (there about a dozen fil

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-18 Thread Mercy Ma
+1 approve Kind Regards, Mercy Ma On Thu, Dec 19, 2019 at 1:15 PM 胡锋 wrote: > Hello Dubbo/Dubbojs Community, > > This is a call for vote to release Apache dubbo-js version v3.0.0-rc2. > > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc2/ > > Git tag for

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-19 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release. [v] Are release files in correct location? [v] Are the digital signature and hashes correct? [v] Do LICENSE and NOTICE files exists? [v] Is the LICENSE and NOTICE text correct? [v] Is the NOTICE year correct? [x] Un-included soft

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-19 Thread Justin Mclean
Hi, This should probably be called rc3 and the previous release was rc2. Everything is OK ASF wise, but I I think you may wan to make this release again as the release incorrectly contains a “.git” folder including this 30MB file [3] I checked: - signature and hashed good - LICENSE and NOTICE

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-22 Thread Jun Liu
+1 binding I checked: * signatures and hashes are good * LICENSE and NOTICE exit and content are good * all source files no binary files As Justin has pointed, some files do not have the right Apache License Header. I am wondering if it’s possible for this project's building tool to add some

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-22 Thread 胡锋
I took a moment to write a script to detect a license file for a nodejs project Jun Liu 于2019年12月23日周一 上午11:03写道: > +1 binding > > I checked: > * signatures and hashes are good > * LICENSE and NOTICE exit and content are good > * all source files no binary files > > As Justin has pointed, som

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-22 Thread Justin Mclean
Hi, Again I would strongly recommend that you not release this because of the 30MB of git internal files contained in the release. Thanks, Justin On Mon, 23 Dec 2019, 14:07 胡锋, wrote: > I took a moment to write a script to detect a license file for a nodejs > project > > Jun Liu 于2019年12月23日周

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-22 Thread 胡锋
I agree with Justin let me fixed it and vote to release Apache dubbo-js version v3.0.0-rc3 Thanks, hufeng Justin Mclean 于2019年12月23日周一 上午11:30写道: > Hi, > > Again I would strongly recommend that you not release this because of the > 30MB of git internal files contained in the release. > > Than