Incompatible license for dependency nacos-client

2019-04-01 Thread Huxing Zhang
Hi, When I am looking at this issue[1], I realized that Dubbo may have the same issue. >From Dubbo 2.7.1 and 2.6.6 onwards the Nacos support has been added, where the following dependency has been added: com.alibaba.nacos nacos-client ${nacos.version} true which depend on the f

Re: Incompatible license for dependency nacos-client

2019-04-01 Thread YunKun Huang
I guess those two plugin can help: 1. mvn project-info-reports:dependencies it will generate a html file in target/site folder, and list all dependencies license 2.mvn project-info-reports:licenses it will generate a license report (plain text) in src/license and allow you to fill license info

Re: Incompatible license for dependency nacos-client

2019-04-01 Thread YunKun Huang
Sorry, I copy wrong one for second one Second one should be `mvn license:add-third-party -Dlicense.useMissingFile` On 2019/04/01 11:22:03, YunKun Huang wrote: > I guess those two plugin can help: > > 1. mvn project-info-reports:dependencies > it will generate a html file in target/site folder,

Re: Incompatible license for dependency nacos-client

2019-04-01 Thread Huxing Zhang
Hi, Thanks for the suggestion. I tried the following commands: `mvn license:add-third-party -Dlicense.useMissingFile` The command outputs all the 3rd party licenses for the module. I did a further investigation with the following commands: find . -name THIRD-PARTY.txt | xargs grep GPL | grep -v

Re: Incompatible license for dependency nacos-client

2019-04-01 Thread Ian Luo
We should contact nacos's developer to fix this dependency issue. -Ian. On Mon, Apr 1, 2019 at 6:15 PM Huxing Zhang wrote: > Hi, > > When I am looking at this issue[1], I realized that Dubbo may have the > same issue. > From Dubbo 2.7.1 and 2.6.6 onwards the Nacos support has been added, > wher

Re: Incompatible license for dependency nacos-client

2019-04-02 Thread Huxing Zhang
Hi, It looks like the dependencies with incompatible licenses have been removed on the Nacos side. So I think Dubbo should upgrade to the latest version once there is a release. On Tue, Apr 2, 2019 at 10:28 AM Ian Luo wrote: > > We should contact nacos's developer to fix this dependency issue. >

Re: Incompatible license for dependency nacos-client

2019-04-03 Thread Huxing Zhang
Hi, The latest nacos client 1.0.0-RC3 has been rolled out. I will follow up tomorrow. [1] https://mvnrepository.com/artifact/com.alibaba.nacos/nacos-client/1.0.0-RC3 On Tue, Apr 2, 2019 at 5:59 PM Huxing Zhang wrote: > > Hi, > > It looks like the dependencies with incompatible licenses have bee

Re: Incompatible license for dependency nacos-client

2019-04-07 Thread Ian Luo
Great, let's target it to 2.7.2. I have moved the issue [1] into 2.7.2's bucket. -Ian. 1. https://github.com/apache/incubator-dubbo/issues/3804 On Tue, Apr 2, 2019 at 5:59 PM Huxing Zhang wrote: > Hi, > > It looks like the dependencies with incompatible licenses have been > removed on the Naco

Re: Incompatible license for dependency nacos-client

2019-04-07 Thread Huxing Zhang
Hi, I've send a pull request: https://github.com/apache/incubator-dubbo/pull/3810 It would be appreciated if someone could help to review it. On Wed, Apr 3, 2019 at 11:20 PM Huxing Zhang wrote: > > Hi, > > The latest nacos client 1.0.0-RC3 has been rolled out. I will follow > up tomorrow. > > [1

Re: Incompatible license for dependency nacos-client

2019-04-07 Thread Ian Luo
Merged, but we still need to bump up nacos's version when it gets official. -Ian. On Mon, Apr 8, 2019 at 2:17 PM Huxing Zhang wrote: > Hi, > > I've send a pull request: > https://github.com/apache/incubator-dubbo/pull/3810 > It would be appreciated if someone could help to review it. > > On Wed

Re: Incompatible license for dependency nacos-client

2019-04-07 Thread Huxing Zhang
Hi, On Mon, Apr 8, 2019 at 2:35 PM Ian Luo wrote: > > Merged, but we still need to bump up nacos's version when it gets official. Thanks and agreed. > > -Ian. > > On Mon, Apr 8, 2019 at 2:17 PM Huxing Zhang wrote: > > > Hi, > > > > I've send a pull request: > > https://github.com/apache/incuba

Re: Incompatible license for dependency nacos-client

2019-04-08 Thread YunKun Huang
Should we add this check in travis CI or do this check each time for a new dependency added On 2019/04/08 06:09:56, Ian Luo wrote: > Great, let's target it to 2.7.2. I have moved the issue [1] into 2.7.2's > bucket. > > -Ian. > > 1. https://github.com/apache/incubator-dubbo/issues/3804 > > O

Re: Incompatible license for dependency nacos-client

2019-04-08 Thread Huxing Zhang
Hi, On Tue, Apr 9, 2019 at 11:14 AM YunKun Huang wrote: > > Should we add this check in travis CI or do this check each time for a new > dependency added The problem is that not every time a new dependency will be added, and the process will take too much time in my local test. My concerns is t

Re: Incompatible license for dependency nacos-client

2019-04-08 Thread Ian Luo
Good idea. Should we introduce a script to guard against this first? Thanks, -Ian. On Tue, Apr 9, 2019 at 11:14 AM YunKun Huang wrote: > Should we add this check in travis CI or do this check each time for a new > dependency added > > On 2019/04/08 06:09:56, Ian Luo wrote: > > Great, let's tar

Re: Incompatible license for dependency nacos-client

2019-04-09 Thread YunKun Huang
Yeah. this check process is slow in my local machine. I agree with doing it manually On 2019/04/09 03:29:35, Huxing Zhang wrote: > Hi, > > On Tue, Apr 9, 2019 at 11:14 AM YunKun Huang wrote: > > > > Should we add this check in travis CI or do this check each time for a new > > dependency adde

Re: Incompatible license for dependency nacos-client

2019-04-09 Thread Ian Luo
Let's introduce a convenient script first and put it in the root directory. YuKun, would you mind to take this? Thanks, -Ian. On Tue, Apr 9, 2019 at 5:47 PM YunKun Huang wrote: > Yeah. this check process is slow in my local machine. > I agree with doing it manually > > On 2019/04/09 03:29:35, H

Re: Incompatible license for dependency nacos-client

2019-04-09 Thread YunKun Huang
yeah. I can take this one and prepare a script On 2019/04/10 02:30:16, Ian Luo wrote: > Let's introduce a convenient script first and put it in the root directory. > YuKun, would you mind to take this? > > Thanks, > -Ian. > > On Tue, Apr 9, 2019 at 5:47 PM YunKun Huang wrote: > > > Yeah. t