PR raised for dubbo-config-api

Hi All, I have raised PR for dubbo-config-api. In this PR have replaced the pending hard coded values with constant so that we can minimize accidental issue due to hard coded value used in multiple places. I have created the issue (3107

Re: PR raised for dubbo-config-api

Imteyaz, The change looks good to me, but I have a minor comment on your change. Would you mind to take a look? Thanks, -Ian. On Mon, Dec 31, 2018 at 10:57 PM Imteyaz Khan wrote: > Hi All, > I have raised PR > for > dubbo-config-api. In

Re: PR raised for dubbo-config-api

Sure. I appreciate you comment and I am on it. On Wed, Jan 2, 2019 at 2:49 PM Ian Luo wrote: > Imteyaz, > > The change looks good to me, but I have a minor comment on your change. > Would you mind to take a look? > > Thanks, > -Ian. > > On Mon, Dec 31, 2018 at 10:57 PM Imteyaz Khan > wrote: > >

Re: PR raised for dubbo-config-api

Ian, I have incorporated the changes, could you have a look and provide me your feedback. On Wed, Jan 2, 2019 at 3:08 PM Imteyaz Khan wrote: > Sure. I appreciate you comment and I am on it. > > On Wed, Jan 2, 2019 at 2:49 PM Ian Luo wrote: > >> Imteyaz, >> >> The change looks good to me, but I

Re: PR raised for dubbo-config-api

I merged your PR. Thanks, -Ian. On Wed, Jan 2, 2019 at 5:54 PM Imteyaz Khan wrote: > Ian, I have incorporated the changes, could you have a look and provide me > your feedback. > > On Wed, Jan 2, 2019 at 3:08 PM Imteyaz Khan > wrote: > > > Sure. I appreciate you comment and I am on it. > > > >