[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...

2015-12-30 Thread qingwen220
Github user qingwen220 closed the pull request at: https://github.com/apache/incubator-eagle/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...

2015-12-29 Thread qingwen220
Github user qingwen220 commented on the pull request: https://github.com/apache/incubator-eagle/pull/46#issuecomment-167922198 Yes, I agree with your comments. Thanks. I will update the scripts. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...

2015-12-29 Thread yonzhang
Github user yonzhang commented on the pull request: https://github.com/apache/incubator-eagle/pull/46#issuecomment-167907289 another comments: can we make this tool into eagle-external? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...

2015-12-29 Thread yonzhang
Github user yonzhang commented on the pull request: https://github.com/apache/incubator-eagle/pull/46#issuecomment-167904154 more comments: 1) site attribute should be part of metric dimension 2) I would suggest we change attribute name "type" to "component" --- If your projec

[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...

2015-12-29 Thread yonzhang
Github user yonzhang commented on the pull request: https://github.com/apache/incubator-eagle/pull/46#issuecomment-167901101 Comments: 1. I want to apply the patch in my local machine. It fails, you will have the same issue when you apply the patch to master. You probably need coll

[GitHub] incubator-eagle pull request: EAGLE-100 Provide tools to collect h...

2015-12-28 Thread qingwen220
GitHub user qingwen220 opened a pull request: https://github.com/apache/incubator-eagle/pull/46 EAGLE-100 Provide tools to collect hadoop jmx metrics https://issues.apache.org/jira/browse/EAGLE-100 You can merge this pull request into a Git repository by running: $ git pull ht