[GitHub] incubator-eagle pull request: EAGLE-177 Replace Legacy "dataSource...

2016-03-03 Thread haoch
Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/108#issuecomment-191866196 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] incubator-eagle pull request: EAGLE-177 Replace Legacy "dataSource...

2016-03-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-eagle/pull/108 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] incubator-eagle pull request: EAGLE-177 Replace Legacy "dataSource...

2016-03-03 Thread RalphSu
Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/108#issuecomment-191681816 +1 Unit runs ok for me. Be careful this would be incompatible for existing deployment if one already deployed. The one who already load the format of o

[GitHub] incubator-eagle pull request: EAGLE-177 Replace Legacy "dataSource...

2016-03-03 Thread qingwen220
GitHub user qingwen220 opened a pull request: https://github.com/apache/incubator-eagle/pull/108 EAGLE-177 Replace Legacy "dataSource" field with "application" in all metadata https://issues.apache.org/jira/browse/EAGLE-177 You can merge this pull request into a Git repository by r