[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user asfgit closed the pull request at: https://github.com/apache/incubator-eagle/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/27#issuecomment-164467062 LGTM. Thanks very much for the contribution! @RalphSu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/27#issuecomment-164463110 `shengli` should be someone's internal account name :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/27#issuecomment-164459877 Make them as more meaningless ones t1 t2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/27#issuecomment-164449409 i don't see why test_lateral_view_shengli/bm2_item4_5 are sensitive? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/27#issuecomment-164424948 https://github.com/RalphSu/incubator-eagle/blob/master/eagle-security/eagle-security-hive/src/test/java/org/apache/eagle/security/hive/ql/TestParser.java#L126

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/27#issuecomment-164424435 Thanks for the fix but seems not completely clean yet :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user RalphSu commented on the pull request: https://github.com/apache/incubator-eagle/pull/27#issuecomment-164414066 Updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/27#issuecomment-164404890 There are some sensitive table/field name in the unit test case sql, please rename/remove. --- If your project is set up for it, you can reply to this email and h

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/27#discussion_r47482020 --- Diff: eagle-security/eagle-security-hive/src/test/java/org/apache/eagle/security/hive/ql/TestParser.java --- @@ -248,9 +249,11 @@ public void testD

[GitHub] incubator-eagle pull request: EAGLE-85 : Fix unit test failure.

GitHub user RalphSu opened a pull request: https://github.com/apache/incubator-eagle/pull/27 EAGLE-85 : Fix unit test failure. Fix the failed test cases. 1. avoid hive sql in test case using reserved words which fails the hive parser. https://cwiki.apache.org/confluence/dis