blob/develop/
> eagle-dev/checkstyle.xml#L236
>
> -Original Message-
> From: Michael Wu [mailto:mchl@gmail.com]
> Sent: 2016年8月25日 13:09
> To: dev@eagle.incubator.apache.org
> Subject: Re: Please take notice to check-in only meaningful javadoc.
>
> No, for m
: Please take notice to check-in only meaningful javadoc.
No, for most buildings including PR verification, develop check-in, we don't
have to run javadoc phase. The issue was exposed when I tried to deploy
snapshot artifacts, using jdk1.8.x to compile and execute deploying commands
which include
No, for most buildings including PR verification, develop check-in, we
don't have to run javadoc phase. The issue was exposed when I tried to
deploy snapshot artifacts, using jdk1.8.x to compile and execute deploying
commands which include the javadoc phase by default.
On Thu, Aug 25, 2016 at
Run 'mvn javadoc:javadoc javadoc:test-javadoc', it now immediately failed
:-(
So looks like mvn javadoc can find out useless param. Do we need do both
checkstyle and javadoc while in building?
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:2.9.1:javadoc
This bugs me too. FWIW, in Calcite we run ‘mvn javadoc:javadoc
javadoc:test-javadoc’ as part of the automated build (as of JDK 1.8, javadoc is
quite strict). Neither javadoc nor checkstyle will flag useless javadoc like
‘@param x’, so I wrote a checkstyle module[1] and call it from Calcite’s
Good reminding. @Contributors, not only about java docs, pls. make sure all
the code style matches the checkstyle, currently I just keep the checkstyle
as WARNING as we still have lots of style warning to clean, in future we
should throw ERROR if any check-style doesn't match. Pls. start to spend
Hi guys,
Recently, when I tried to deploy eagle 0.5.0-incubating-snapshot artifacts
based on develop branch, the entire build flow was broken by lots of faulty
javadoc, which are classified in following aspects. I'll try to erase
illegal/meaningless javadoc, and please PAY ATTENTION to your
