Re: samples repo

Lower priority than resuming/pushing out the release IMO :-) The workaround is tolerable if it ends up as is. > On Nov 22, 2017, at 12:38 PM, Christofer Dutz > wrote: > > Hi Dale, > > I’ll look into this problem … there must be something else wrong cause that’s >

Re: samples repo

Hi Dale, I’ll look into this problem … there must be something else wrong cause that’s the exact same way it should work … but I’ll only manage to do that tomorrow. Chris Am 22.11.17, 18:31 schrieb "Dale LaBossiere" : I can’t “explain" the mvn behavior :-) But you

time to create a PR and merge features/pre-release-finetuning?

Chris, if you create a PR, I’ll merge it (or you can). Then I’ll create a PR for removing the samples and do that. Then you can remove the release branch and start it up again. Make sense? P.S. it’s Thanksgiving holiday in the US so response from me may be delayed a bit. — Dale

Re: samples repo

I can’t “explain" the mvn behavior :-) But you can observe the result yourself: - get the latest sample repo code on the develop branch - ./mvnw clean package # expect to fail because the pom is trying to use runtime version 1.2.0 - ./mvnw clean package -Dedgent.runtime.version=1.2.0-SNAPSHOT

Re: samples repo

Hi Dale, Öhm … could you explain why? Usually –D property values have the highest priority. Chris Am 22.11.17, 18:04 schrieb "Dale LaBossiere" : > On Nov 21, 2017, at 5:10 PM, Dale LaBossiere wrote: > Prior to that time, when building

Re: samples repo

> On Nov 21, 2017, at 5:10 PM, Dale LaBossiere wrote: > Prior to that time, when building the samples, one can do > ./mvnw clean package -Dedgent.runtime.version=1.2.0-SNAPSHOT # assuming > you’ve done an “install” of that runtime version arrg… due to maven-isms,

[GitHub] incubator-edgent-samples pull request #4: Update info about building against...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-edgent-samples/pull/4 ---

[GitHub] incubator-edgent-samples pull request #3: ignore maven wrapper jar in templa...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-edgent-samples/pull/3 ---

[GitHub] incubator-edgent-samples pull request #3: ignore maven wrapper jar in templa...

GitHub user dlaboss opened a pull request: https://github.com/apache/incubator-edgent-samples/pull/3 ignore maven wrapper jar in template You can merge this pull request into a Git repository by running: $ git pull https://github.com/dlaboss/incubator-edgent-samples gitignore