samples repo doc

2017-12-05 Thread Dale LaBossiere
Hi all, I would be very helpful if some could review the doc in the new samples repo https://github.com/apache/incubator-edgent-samples <https://github.com/apache/incubator-edgent-samples> starting with the README.md and following the doc links it references. While 1.2.0 has not ye

Re: samples repo

2017-11-23 Thread Dale LaBossiere
If you haven’t already noticed them, pls see the review/comments I added to the PR. — Dale (signing off for the day) > On Nov 23, 2017, at 3:32 AM, Christofer Dutz > wrote: > > Hi Dale, > > cool thing if you have a problem in the back of your mind … you tend to come > up with solutions when

Re: samples repo

2017-11-23 Thread Christofer Dutz
Hi Dale, cool thing if you have a problem in the back of your mind … you tend to come up with solutions when you don’t expect them ;-) Guess the problems we were having was due to the order in which maven initializes things. In this case I think inheritance is done before overriding. So, if the

Re: samples repo

2017-11-22 Thread Dale LaBossiere
Lower priority than resuming/pushing out the release IMO :-) The workaround is tolerable if it ends up as is. > On Nov 22, 2017, at 12:38 PM, Christofer Dutz > wrote: > > Hi Dale, > > I’ll look into this problem … there must be something else wrong cause that’s > the exact same way it should

Re: samples repo

2017-11-22 Thread Christofer Dutz
Hi Dale, I’ll look into this problem … there must be something else wrong cause that’s the exact same way it should work … but I’ll only manage to do that tomorrow. Chris Am 22.11.17, 18:31 schrieb "Dale LaBossiere" : I can’t “explain" the mvn behavior :-) But you can observe the result

Re: samples repo

2017-11-22 Thread Dale LaBossiere
I can’t “explain" the mvn behavior :-) But you can observe the result yourself: - get the latest sample repo code on the develop branch - ./mvnw clean package # expect to fail because the pom is trying to use runtime version 1.2.0 - ./mvnw clean package -Dedgent.runtime.version=1.2.0-SNAPSHOT

Re: samples repo

2017-11-22 Thread Christofer Dutz
Hi Dale, Öhm … could you explain why? Usually –D property values have the highest priority. Chris Am 22.11.17, 18:04 schrieb "Dale LaBossiere" : > On Nov 21, 2017, at 5:10 PM, Dale LaBossiere wrote: > Prior to that time, when building the samples, one can do > ./mvnw clea

Re: samples repo

2017-11-22 Thread Dale LaBossiere
> On Nov 21, 2017, at 5:10 PM, Dale LaBossiere wrote: > Prior to that time, when building the samples, one can do > ./mvnw clean package -Dedgent.runtime.version=1.2.0-SNAPSHOT # assuming > you’ve done an “install” of that runtime version arrg… due to maven-isms, overriding via -D doesn’t

samples repo

2017-11-21 Thread Dale LaBossiere
Chris, As you may have noticed, I’ve created and merged the first samples PR [1] (see it for comments) I’ll look through other doc in the core repo and take care of anything that needs updating. As soon as practical we can remove the samples from the core repo. I think the samples-develop bran