[GitHub] [incubator-eventmesh] HoffmanZheng commented on pull request #867: [ISSUE-856] Add test code for module [eventmesh-trace-plugin]

2022-05-17 Thread GitBox
HoffmanZheng commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1128886964 > > > `eventmesh-trace-plugin/eventmesh-trace-zipkin/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker`, @HoffmanZheng hi, you need add the apache

[GitHub] [incubator-eventmesh] HoffmanZheng commented on pull request #867: [ISSUE-856] Add test code for module [eventmesh-trace-plugin]

2022-05-16 Thread GitBox
HoffmanZheng commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1128407366 > `eventmesh-trace-plugin/eventmesh-trace-zipkin/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker`, @HoffmanZheng hi, you need add the apache license

[GitHub] [incubator-eventmesh] HoffmanZheng commented on pull request #867: [ISSUE-856] Add test code for module [eventmesh-trace-plugin]

2022-05-16 Thread GitBox
HoffmanZheng commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1127442988 It seems that mocking a final class is [still a incubating

[GitHub] [incubator-eventmesh] HoffmanZheng commented on pull request #867: [ISSUE-856] Add test code for module [eventmesh-trace-plugin]

2022-05-15 Thread GitBox
HoffmanZheng commented on PR #867: URL: https://github.com/apache/incubator-eventmesh/pull/867#issuecomment-1127119225 There is no exposed behavior in