[GitHub] [eventmesh-site] MajorHe1 merged pull request #78: Update the-apache-software-foundation-announces-new-top-level-project…

2023-04-12 Thread via GitHub
MajorHe1 merged PR #78: URL: https://github.com/apache/eventmesh-site/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [eventmesh-site] qqeasonchen opened a new pull request, #78: Update the-apache-software-foundation-announces-new-top-level-project…

2023-04-12 Thread via GitHub
qqeasonchen opened a new pull request, #78: URL: https://github.com/apache/eventmesh-site/pull/78 …-apache-eventmesh.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [eventmesh] dipankr opened a new pull request, #3712: [ISSUE #3652] refactored the code, extracted a new method and used switch

2023-04-12 Thread via GitHub
dipankr opened a new pull request, #3712: URL: https://github.com/apache/eventmesh/pull/3712 Fixes #3652. ### Motivation *there were duplicate code in the file, refactored the duplicate code to a method and refactored further to make the code more readable*

[GitHub] [eventmesh-site] xwm1992 merged pull request #77: fix error

2023-04-12 Thread via GitHub
xwm1992 merged PR #77: URL: https://github.com/apache/eventmesh-site/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [eventmesh-site] xwm1992 merged pull request #73: Update roadmap.md

2023-04-12 Thread via GitHub
xwm1992 merged PR #73: URL: https://github.com/apache/eventmesh-site/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [eventmesh-site] xwm1992 merged pull request #76: fix error

2023-04-12 Thread via GitHub
xwm1992 merged PR #76: URL: https://github.com/apache/eventmesh-site/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [eventmesh] dipankr closed pull request #3711: [ ISSUE #3652] refactored code

2023-04-12 Thread via GitHub
dipankr closed pull request #3711: [ ISSUE #3652] refactored code URL: https://github.com/apache/eventmesh/pull/3711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [eventmesh] dipankr opened a new pull request, #3711: [ ISSUE #3652] refactored code

2023-04-12 Thread via GitHub
dipankr opened a new pull request, #3711: URL: https://github.com/apache/eventmesh/pull/3711 Fixes #3652. ### Motivation *Explain the content here.* *Explain why you want to make the changes and what problem you're trying to solve.* there were duplicate

[GitHub] [eventmesh] akashsawan1 opened a new pull request, #3710: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java

2023-04-12 Thread via GitHub
akashsawan1 opened a new pull request, #3710: URL: https://github.com/apache/eventmesh/pull/3710 Closes#<3408> Motivation Explain why you want to make the changes and what problem you're trying to solve. I am contributing for the first time, it will help to keep me

[GitHub] [eventmesh] akashsawan1 closed pull request #3706: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java #3408

2023-04-12 Thread via GitHub
akashsawan1 closed pull request #3706: [ISSUE #3408]Update SendAsyncRemoteEventProcessor.java #3408 URL: https://github.com/apache/eventmesh/pull/3706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: Request for Consideration of Squash Commits in Merge Requests

2023-04-12 Thread Francois Papon
+1 On 12/04/2023 10:16, Eason Chen wrote: Seems ok to me. On Wed, Apr 12, 2023 at 3:58 PM ZhangJian He wrote: Hello community members, would you like to share any thoughts, ideas, or feedback? Thanks ZhangJian He On 2023/03/29 12:39:16 ZhangJian He wrote: Hello, community! I would like

[GitHub] [eventmesh] dipankr opened a new pull request, #3709: [ISSUE #3653] refactored code and extracted method

2023-04-12 Thread via GitHub
dipankr opened a new pull request, #3709: URL: https://github.com/apache/eventmesh/pull/3709 …umber of line of duplicate code Fixes #3653. ### Motivation we have a few lines of duplicate code and the suggestion was to extract it to a method

[GitHub] [eventmesh] willimpo opened a new pull request, #3708: [ISSUE #3707]fix thread leak with rocketmq consumer start and shutdown frequently

2023-04-12 Thread via GitHub
willimpo opened a new pull request, #3708: URL: https://github.com/apache/eventmesh/pull/3708 Fixes #<3707>. ### Motivation when using rocketmq as eventmesh storage,and consumer groups are frequently started and shutdown. The number of threads in the process

[GitHub] [eventmesh] akashsawan1 opened a new pull request, #3706: Update SendAsyncRemoteEventProcessor.java #3408

2023-04-12 Thread via GitHub
akashsawan1 opened a new pull request, #3706: URL: https://github.com/apache/eventmesh/pull/3706 Closes#<3408> Motivation Explain why you want to make the changes and what problem you're trying to solve. I am contributing for the first time, it will help to keep me

[GitHub] [eventmesh] monish-byte opened a new pull request, #3705: [Enhancement] Code reuse is extracted as a method.[GrpcMessageProtocolResolver].

2023-04-12 Thread via GitHub
monish-byte opened a new pull request, #3705: URL: https://github.com/apache/eventmesh/pull/3705 Fixes #3651. ### Motivation *Explain the content here.* *Explain why you want to make the changes and what problem you're trying to solve.* ###

[GitHub] [eventmesh-site] MajorHe1 merged pull request #75: add asf annoucne

2023-04-12 Thread via GitHub
MajorHe1 merged PR #75: URL: https://github.com/apache/eventmesh-site/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [eventmesh] nikam14 opened a new pull request, #3704: fixes #3246

2023-04-12 Thread via GitHub
nikam14 opened a new pull request, #3704: URL: https://github.com/apache/eventmesh/pull/3704 made the changes mentioned in the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [eventmesh-site] qqeasonchen merged pull request #74: [doc](01-contribute)fixed broken link.

2023-04-12 Thread via GitHub
qqeasonchen merged PR #74: URL: https://github.com/apache/eventmesh-site/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [eventmesh-site] nikam14 opened a new pull request, #74: [doc](01-contribute)fixed broken link.

2023-04-12 Thread via GitHub
nikam14 opened a new pull request, #74: URL: https://github.com/apache/eventmesh-site/pull/74 In the section of Documentation improvement a hyperlink was broken . improved that hyperlink. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: Request for Consideration of Squash Commits in Merge Requests

2023-04-12 Thread Eason Chen
Seems ok to me. On Wed, Apr 12, 2023 at 3:58 PM ZhangJian He wrote: > > Hello community members, would you like to share any thoughts, ideas, or > feedback? > > Thanks > ZhangJian He > > > On 2023/03/29 12:39:16 ZhangJian He wrote: > > Hello, community! > > I would like to bring up a topic for

RE: Request for Consideration of Squash Commits in Merge Requests

2023-04-12 Thread ZhangJian He
Hello community members, would you like to share any thoughts, ideas, or feedback? Thanks ZhangJian He On 2023/03/29 12:39:16 ZhangJian He wrote: > Hello, community! > I would like to bring up a topic for discussion regarding our git commits. > I noticed that we have not been using the "squash

[GitHub] [eventmesh] nikam14 opened a new pull request, #3703: [MINOR] made some optimisation

2023-04-12 Thread via GitHub
nikam14 opened a new pull request, #3703: URL: https://github.com/apache/eventmesh/pull/3703 ### Motivation Made some optimization in file. ### Modifications removed the repetition of function call. ### Documentation

[GitHub] [eventmesh] xwm1992 merged pull request #3697: [ISSUE #3513] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]

2023-04-12 Thread via GitHub
xwm1992 merged PR #3697: URL: https://github.com/apache/eventmesh/pull/3697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [eventmesh] xwm1992 merged pull request #3698: [ISSUE #2975] removed String.format()

2023-04-12 Thread via GitHub
xwm1992 merged PR #3698: URL: https://github.com/apache/eventmesh/pull/3698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: