Re: Review Request 41601: Add CLI option to display captured replication metrics

2016-01-08 Thread Ying Zheng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41601/#review113567 --- client/src/main/java/org/apache/falcon/client/FalconClient.java (l

Re: Review Request 41601: Add CLI option to display captured replication metrics

2016-01-08 Thread Venkat Ranganathan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41601/#review113500 --- Ship it! LGTM. Thanks for incorporating the review comments. -

[jira] [Commented] (FALCON-1643) Add CLI option to display captured replication metrics

2016-01-08 Thread Peeyush Bishnoi (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089386#comment-15089386 ] Peeyush Bishnoi commented on FALCON-1643: - Thansk [~bvellanki] for reviewing the

Re: Review Request 41601: Add CLI option to display captured replication metrics

2016-01-08 Thread Peeyush Bishnoi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41601/ --- (Updated Jan. 8, 2016, 3:52 p.m.) Review request for Falcon. Changes ---

[jira] [Updated] (FALCON-1643) Add CLI option to display captured replication metrics

2016-01-08 Thread Peeyush Bishnoi (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peeyush Bishnoi updated FALCON-1643: Attachment: FALCON-1643.v3.patch > Add CLI option to display captured replication metrics >

[jira] [Comment Edited] (FALCON-1230) Data based notification Service to notify execution instances when data becomes available

2016-01-08 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089346#comment-15089346 ] Ajay Yadava edited comment on FALCON-1230 at 1/8/16 3:34 PM: -

[jira] [Commented] (FALCON-1230) Data based notification Service to notify execution instances when data becomes available

2016-01-08 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089346#comment-15089346 ] Ajay Yadava commented on FALCON-1230: - I know that you have several patches which nee

[jira] [Commented] (FALCON-1230) Data based notification Service to notify execution instances when data becomes available

2016-01-08 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089342#comment-15089342 ] Ajay Yadava commented on FALCON-1230: - Thanks [~pavan kumar] I have put my feedback o

Re: Review Request 39632: Data Availability Service for Falcon

2016-01-08 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39632/#review113478 --- scheduler/src/main/java/org/apache/falcon/notification/service/imp

Re: Review Request 41601: Add CLI option to display captured replication metrics

2016-01-08 Thread Peeyush Bishnoi
> On Jan. 7, 2016, 9:20 p.m., Balu Vellanki wrote: > > @Balu, Thanks a lot for reviewing this. > On Jan. 7, 2016, 9:20 p.m., Balu Vellanki wrote: > > client/src/main/java/org/apache/falcon/cli/FalconMetadataCLI.java, line 162 > >

Re: Review Request 41978: SLA Monitoring does not honour entity end date

2016-01-08 Thread Ajay Yadava
> On Jan. 8, 2016, 5:06 a.m., pavan kumar kolamuri wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 344 > > > > > > If entity end time is over why we are not calling o

[jira] [Commented] (FALCON-1168) Native Scheduler in Falcon - Umbrella JIRA

2016-01-08 Thread Pragya Mittal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089183#comment-15089183 ] Pragya Mittal commented on FALCON-1168: --- Adding FALCON-1739 to track the API respon

[jira] [Updated] (FALCON-1741) Rerun API behaviour different in case of succeeded instances

2016-01-08 Thread Pragya Mittal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pragya Mittal updated FALCON-1741: -- Description: In case of succeeded instances , rerun without -force API has different behaviour

[jira] [Updated] (FALCON-1741) Rerun API behaviour different in case of succeeded instances

2016-01-08 Thread Pragya Mittal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pragya Mittal updated FALCON-1741: -- Description: In case of succeeded instances , rerun without -force API has different behaviour

[jira] [Updated] (FALCON-1741) Rerun API behaviour different in case of succeeded instances

2016-01-08 Thread Pragya Mittal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pragya Mittal updated FALCON-1741: -- Description: In case of succeeded instances , rerun without -force API has different behaviour

[jira] [Created] (FALCON-1741) Rerun API behaviour different in case of succeeded instances

2016-01-08 Thread Pragya Mittal (JIRA)
Pragya Mittal created FALCON-1741: - Summary: Rerun API behaviour different in case of succeeded instances Key: FALCON-1741 URL: https://issues.apache.org/jira/browse/FALCON-1741 Project: Falcon

[jira] [Updated] (FALCON-1740) Killed API response in case of succeeded instances

2016-01-08 Thread Pragya Mittal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pragya Mittal updated FALCON-1740: -- Description: In case of succeeded instances , killed API has different behaviour based on the

[jira] [Updated] (FALCON-1740) Killed API response in case of succeeded instances

2016-01-08 Thread Pragya Mittal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pragya Mittal updated FALCON-1740: -- Description: In case of succeeded instances , killed API has different behaviour based on the

[jira] [Updated] (FALCON-1740) Killed API response in case of succeeded instances

2016-01-08 Thread Pragya Mittal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pragya Mittal updated FALCON-1740: -- Description: In case of succeeded instances , killed API has different behaviour based on the

[jira] [Created] (FALCON-1740) Killed API response in case of succeeded instances

2016-01-08 Thread Pragya Mittal (JIRA)
Pragya Mittal created FALCON-1740: - Summary: Killed API response in case of succeeded instances Key: FALCON-1740 URL: https://issues.apache.org/jira/browse/FALCON-1740 Project: Falcon Issue T

[jira] [Updated] (FALCON-1739) Tracking API differences between Native Scheduler and Oozie

2016-01-08 Thread Pragya Mittal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pragya Mittal updated FALCON-1739: -- Description: Ideally end user should be unaware of the behaviour of API result irrespective of

[jira] [Created] (FALCON-1739) Tracking API differences between Native Scheduler and Oozie

2016-01-08 Thread Pragya Mittal (JIRA)
Pragya Mittal created FALCON-1739: - Summary: Tracking API differences between Native Scheduler and Oozie Key: FALCON-1739 URL: https://issues.apache.org/jira/browse/FALCON-1739 Project: Falcon

Re: Review Request 41978: SLA Monitoring does not honour entity end date

2016-01-08 Thread pavan kumar kolamuri
> On Jan. 8, 2016, 5:06 a.m., pavan kumar kolamuri wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 344 > > > > > > If entity end time is over why we are not calling o

[jira] [Commented] (FALCON-1230) Data based notification Service to notify execution instances when data becomes available

2016-01-08 Thread pavan kumar kolamuri (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089137#comment-15089137 ] pavan kumar kolamuri commented on FALCON-1230: -- Raised https://issues.apach

[jira] [Commented] (FALCON-1230) Data based notification Service to notify execution instances when data becomes available

2016-01-08 Thread pavan kumar kolamuri (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089139#comment-15089139 ] pavan kumar kolamuri commented on FALCON-1230: -- [~ajayyadava] Please review

Re: Review Request 39632: Data Availability Service for Falcon

2016-01-08 Thread pavan kumar kolamuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39632/ --- (Updated Jan. 8, 2016, 12:30 p.m.) Review request for Falcon. Changes ---

[jira] [Updated] (FALCON-1230) Data based notification Service to notify execution instances when data becomes available

2016-01-08 Thread pavan kumar kolamuri (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] pavan kumar kolamuri updated FALCON-1230: - Attachment: FALCON-1230-v7.patch > Data based notification Service to notify exec

[jira] [Created] (FALCON-1738) Support Retry for failure Data-based Notifications and fix timeout test case in FalconExecutionServiceTest

2016-01-08 Thread pavan kumar kolamuri (JIRA)
pavan kumar kolamuri created FALCON-1738: Summary: Support Retry for failure Data-based Notifications and fix timeout test case in FalconExecutionServiceTest Key: FALCON-1738 URL: https://issues.apache.org

Re: Review Request 39632: Data Availability Service for Falcon

2016-01-08 Thread pavan kumar kolamuri
> On Jan. 8, 2016, 8:24 a.m., Ajay Yadava wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java, > > line 65 > > > > > > Can you please document in detail the pur

[jira] [Commented] (FALCON-1677) Support re-tries for timed-out instances

2016-01-08 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089079#comment-15089079 ] Ajay Yadava commented on FALCON-1677: - Option 2 looks good to me. To address the back

Re: Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

2016-01-08 Thread Pallavi Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42064/ --- (Updated Jan. 8, 2016, 11 a.m.) Review request for Falcon. Changes --- M

[jira] [Updated] (FALCON-1678) SLA Monitoring does not honour entity end date

2016-01-08 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated FALCON-1678: Attachment: FALCON-1678-v2.patch Forgot to commit removal of an extra import and it got missed in l

[jira] [Updated] (FALCON-1662) Ensure entity can be scheduled on multiple clusters on same colo

2016-01-08 Thread Pallavi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pallavi Rao updated FALCON-1662: Attachment: FALCON-1662-v1.patch Realized delete wasn't idempotent in case of multiple clusters. >

Re: Review Request 41978: SLA Monitoring does not honour entity end date

2016-01-08 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41978/ --- (Updated Jan. 8, 2016, 10:57 a.m.) Review request for Falcon. Bugs: FALCON-16

Re: Review Request 41978: SLA Monitoring does not honour entity end date

2016-01-08 Thread Ajay Yadava
> On Jan. 8, 2016, 5:06 a.m., pavan kumar kolamuri wrote: > > prism/src/main/java/org/apache/falcon/service/FeedSLAMonitoringService.java, > > line 344 > > > > > > If entity end time is over why we are not calling o

[jira] [Commented] (FALCON-1677) Support re-tries for timed-out instances

2016-01-08 Thread pavan kumar kolamuri (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089016#comment-15089016 ] pavan kumar kolamuri commented on FALCON-1677: -- Completely agree with [~pall

[jira] [Commented] (FALCON-1687) Creating archetype for falcon pipelines

2016-01-08 Thread Pallavi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088996#comment-15088996 ] Pallavi Rao commented on FALCON-1687: - Like the idea of a maven archetype. Quickest w

[jira] [Commented] (FALCON-1677) Support re-tries for timed-out instances

2016-01-08 Thread Pallavi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088990#comment-15088990 ] Pallavi Rao commented on FALCON-1677: - My opinion on the approaches: 1) -1 for that.

[jira] [Commented] (FALCON-1677) Support re-tries for timed-out instances

2016-01-08 Thread Narayan Periwal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088985#comment-15088985 ] Narayan Periwal commented on FALCON-1677: - [~ajayyadava], [~pallavi.rao], your su

[jira] [Commented] (FALCON-1728) Process entity definition allows multiple clusters when it has output Feed defined.

2016-01-08 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088984#comment-15088984 ] Ajay Yadava commented on FALCON-1728: - [~bvellanki] Sounds good. (y) > Process entit

[jira] [Commented] (FALCON-1677) Support re-tries for timed-out instances

2016-01-08 Thread Narayan Periwal (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088979#comment-15088979 ] Narayan Periwal commented on FALCON-1677: - There are 3 ways in which we can imple

[jira] [Comment Edited] (FALCON-1737) Ensure DataAvailabilityService handles timeouts across Falcon restarts

2016-01-08 Thread Pallavi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088941#comment-15088941 ] Pallavi Rao edited comment on FALCON-1737 at 1/8/16 9:15 AM: -

[jira] [Commented] (FALCON-1737) Ensure DataAvailabilityService handles timeouts across Falcon restarts

2016-01-08 Thread Pallavi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088941#comment-15088941 ] Pallavi Rao commented on FALCON-1737: - This JIRA is a result of review comments for F

[jira] [Updated] (FALCON-1662) Ensure entity can be scheduled on multiple clusters on same colo

2016-01-08 Thread Pallavi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pallavi Rao updated FALCON-1662: Attachment: FALCON-1662.patch > Ensure entity can be scheduled on multiple clusters on same colo >

Review Request 42064: FALCON-1662 Ensure entity can be scheduled on multiple clusters on same colo

2016-01-08 Thread Pallavi Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42064/ --- Review request for Falcon. Bugs: FALCON-1662 https://issues.apache.org/jira

[jira] [Commented] (FALCON-1737) Ensure DataAvailabilityService handles timeouts across Falcon restarts

2016-01-08 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088925#comment-15088925 ] Ajay Yadava commented on FALCON-1737: - Can we add more details in the description ple

[jira] [Commented] (FALCON-1230) Data based notification Service to notify execution instances when data becomes available

2016-01-08 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088921#comment-15088921 ] Ajay Yadava commented on FALCON-1230: - Sorry I was reviewing one version older and di

[jira] [Commented] (FALCON-1230) Data based notification Service to notify execution instances when data becomes available

2016-01-08 Thread pavan kumar kolamuri (JIRA)
[ https://issues.apache.org/jira/browse/FALCON-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088902#comment-15088902 ] pavan kumar kolamuri commented on FALCON-1230: -- I refactored most of things

Re: Review Request 39632: Data Availability Service for Falcon

2016-01-08 Thread Ajay Yadava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39632/#review106556 --- scheduler/src/main/java/org/apache/falcon/notification/service/imp