[GitHub] felix pull request #88: [converter] compile with org.osgi.util.function 1.0

2017-01-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/felix/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

Re: [VOTE] Release Apache Felix ConfigAdmin 1.8.14

2017-01-30 Thread Raymond Auge
+1 (non-binding) On Mon, Jan 30, 2017 at 2:02 AM, Jean-Baptiste Onofré wrote: > +1 (binding) > > Regards > JB > > > On 01/30/2017 09:48 AM, Carsten Ziegeler wrote: > >> Hi, >> >> We solved 2 issues in this release >> https://issues.apache.org/jira/browse/FELIX/fixforversion/12338956 >> >> >> Sta

[GitHub] felix pull request #88: [converter] compile with org.osgi.util.function 1.0

2017-01-30 Thread njbartlett
GitHub user njbartlett opened a pull request: https://github.com/apache/felix/pull/88 [converter] compile with org.osgi.util.function 1.0 The project contained a copy of `org.osgi.util.function` version 1.1, which includes a small API change. Compiling against the released 1.

Re: Best practice how to generate instances of Component Property types in unit tests

2017-01-30 Thread Carsten Ziegeler
Konrad Windszus wrote > When you use the Component Property Types being introduced with OSGi DS 1.4, > you need to define those as annotation classes. > > For unit tests it is very common, that you need to dynamically generate > several instances of those annotations (when you want to test call

Re: Best practice how to generate instances of Component Property types in unit tests

2017-01-30 Thread David Bosschaert
Hi Konrad, Not really in a unit test but the Converter implements a similar mechanism where it just uses a Java proxy to implement them [1]. Note the use of method.getDefaultValue() to get the default value out of the annotation. Cheers, David [1] https://svn.apache.org/viewvc/felix/trunk/conve

RE: Best practice how to generate instances of Component Property types in unit tests

2017-01-30 Thread Stefan Seifert
if you are using osgi-mock 2.x you can just pass in a map or a list of key/values and they are mapped automatically to an annotation instance and injected within the unit test. stefan [1] https://sling.apache.org/documentation/development/osgi-mock.html >-Original Message- >From: Konr

Re: Best practice how to generate instances of Component Property types in unit tests

2017-01-30 Thread Neil Bartlett
When the Converter specification is released (part of R7) you will be able to use that quite easily, in fact that will be the recommended way. For example to convert a map type: MyAnnotationType config = converter.convert(map).to(MyAnnotationType.class); A converter implementation is a

Best practice how to generate instances of Component Property types in unit tests

2017-01-30 Thread Konrad Windszus
When you use the Component Property Types being introduced with OSGi DS 1.4, you need to define those as annotation classes. For unit tests it is very common, that you need to dynamically generate several instances of those annotations (when you want to test calling the activate() method with

Re: [VOTE] Release Apache Felix ConfigAdmin 1.8.14

2017-01-30 Thread Jean-Baptiste Onofré
+1 (binding) Regards JB On 01/30/2017 09:48 AM, Carsten Ziegeler wrote: Hi, We solved 2 issues in this release https://issues.apache.org/jira/browse/FELIX/fixforversion/12338956 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1164/ You can use this UNIX

Re: [VOTE] Release Apache Felix ConfigAdmin 1.8.14

2017-01-30 Thread Fabian Lange
Hi, I vote +1 (non-binding) Since we discovered the problem and we created a patched version that uses the fix that has been officially merged, the error has been disappeared, no new issues been observed Thanks, Fabian On Mon, Jan 30, 2017 at 9:48 AM, Carsten Ziegeler wrote: > Hi, > > We solve

Re: [VOTE] Release Apache Felix ConfigAdmin 1.8.14

2017-01-30 Thread David Bosschaert
+1 David On 30 January 2017 at 08:48, Carsten Ziegeler wrote: > Hi, > > We solved 2 issues in this release > https://issues.apache.org/jira/browse/FELIX/fixforversion/12338956 > > > Staging repository: > https://repository.apache.org/content/repositories/orgapachefelix-1164/ > > You can use thi

Re: [VOTE] Release Apache Felix ConfigAdmin 1.8.14

2017-01-30 Thread Carsten Ziegeler
+1 -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org

[VOTE] Release Apache Felix ConfigAdmin 1.8.14

2017-01-30 Thread Carsten Ziegeler
Hi, We solved 2 issues in this release https://issues.apache.org/jira/browse/FELIX/fixforversion/12338956 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1164/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache