[jira] [Commented] (FELIX-6058) Add Bundle-Activator metadata back to gogo-jline

2020-04-09 Thread Arnoud Glimmerveen (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079998#comment-17079998 ] Arnoud Glimmerveen commented on FELIX-6058: --- I have opened a new PR on the repository felix-dev

[jira] [Work logged] (FELIX-6058) Add Bundle-Activator metadata back to gogo-jline

2020-04-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6058?focusedWorklogId=419747=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419747 ] ASF GitHub Bot logged work on FELIX-6058: - Author: ASF GitHub Bot

[GitHub] [felix-dev] glimmerveen opened a new pull request #16: [FELIX-6058] Re-added Bundle-Activator to gogo.jline bundle

2020-04-09 Thread GitBox
glimmerveen opened a new pull request #16: [FELIX-6058] Re-added Bundle-Activator to gogo.jline bundle URL: https://github.com/apache/felix-dev/pull/16 Currently the gogo.jline bundle stand-alone is not usable. There was already an open PR on the felix repo

[GitHub] [felix-atomos] tjwatson merged pull request #19: mark equinox profile as activeByDefault

2020-04-09 Thread GitBox
tjwatson merged pull request #19: mark equinox profile as activeByDefault URL: https://github.com/apache/felix-atomos/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [felix-atomos] tjwatson merged pull request #20: Only index duplicate resources

2020-04-09 Thread GitBox
tjwatson merged pull request #20: Only index duplicate resources URL: https://github.com/apache/felix-atomos/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #20: Only index duplicate resources

2020-04-09 Thread GitBox
lgtm-com[bot] commented on issue #20: Only index duplicate resources URL: https://github.com/apache/felix-atomos/pull/20#issuecomment-611699607 This pull request **introduces 1 alert** when merging d67295f26a01b78d4949b3616ba4257a24ccd0f0 into 301ea6a21870592e607aef7623ef13ec8552233a -

[GitHub] [felix-atomos] stbischof commented on issue #20: Only index duplicate resources

2020-04-09 Thread GitBox
stbischof commented on issue #20: Only index duplicate resources URL: https://github.com/apache/felix-atomos/pull/20#issuecomment-611685536 I expected that we need more pre and post (each and all) method's. But i thought that's to much for the moment. So feel free do add them where

[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #20: Only index duplicate resources

2020-04-09 Thread GitBox
lgtm-com[bot] commented on issue #20: Only index duplicate resources URL: https://github.com/apache/felix-atomos/pull/20#issuecomment-611684882 This pull request **introduces 1 alert** when merging 76795dbded19bba9218c82d444c2733ce35659ef into 301ea6a21870592e607aef7623ef13ec8552233a -

[GitHub] [felix-atomos] tjwatson commented on issue #20: Only index duplicate resources

2020-04-09 Thread GitBox
tjwatson commented on issue #20: Only index duplicate resources URL: https://github.com/apache/felix-atomos/pull/20#issuecomment-611681166 @stbischof I added a new method to `org.apache.felix.atomos.utils.api.plugin.JarPlugin.initJar(JarFile, Context, URLClassLoader)` which is called by

[GitHub] [felix-atomos] tjwatson opened a new pull request #20: Only index duplicate resources

2020-04-09 Thread GitBox
tjwatson opened a new pull request #20: Only index duplicate resources URL: https://github.com/apache/felix-atomos/pull/20 The atomos bundles.index should list ALL entries of each bundle, but the resources stored in the atomos/ index directory should only include the resources that

[GitHub] [felix-atomos] tjwatson merged pull request #15: more flexible substrate builder

2020-04-09 Thread GitBox
tjwatson merged pull request #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible substrate builder

2020-04-09 Thread GitBox
lgtm-com[bot] commented on issue #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611535466 This pull request **introduces 3 alerts** and **fixes 3** when merging 8f2a920b9ebbdc5f116170553c0227693e9de255 into

[GitHub] [felix-atomos] tjwatson commented on issue #19: mark equinox profile as activeByDefault

2020-04-09 Thread GitBox
tjwatson commented on issue #19: mark equinox profile as activeByDefault URL: https://github.com/apache/felix-atomos/pull/19#issuecomment-611521839 I'll have to test this out. Before when I tried this then when building with other profiles (e.g. -Pjava8 or -Psubstrate) it would disable

[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible substrate builder

2020-04-09 Thread GitBox
lgtm-com[bot] commented on issue #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611491091 This pull request **introduces 3 alerts** and **fixes 3** when merging dfcec3ae000fc403ea31db86bca24b0eb1c3d00f into

[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible substrate builder

2020-04-09 Thread GitBox
lgtm-com[bot] commented on issue #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611481726 This pull request **introduces 3 alerts** and **fixes 3** when merging 6c354c1917d094aa6df1b32c95f0f30da2ad0c81 into

[GitHub] [felix-atomos] stbischof opened a new pull request #19: mark equinox profile as activeByDefault

2020-04-09 Thread GitBox
stbischof opened a new pull request #19: mark equinox profile as activeByDefault URL: https://github.com/apache/felix-atomos/pull/19 It should be enough to mark one of the existing profiles as activeByDefault. So we can remove the profile with the name default

[GitHub] [felix-atomos] lgtm-com[bot] commented on issue #15: more flexible substrate builder

2020-04-09 Thread GitBox
lgtm-com[bot] commented on issue #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15#issuecomment-611427567 This pull request **introduces 3 alerts** and **fixes 3** when merging 5ac879f4b2c2040552a207e49cb9f9ae59b64e08 into