Re: [PR] FELIX-6692 Add Jetty WebSocket support for jetty 11.x [felix-dev]

2024-04-30 Thread via GitHub
paulrutter commented on PR #309: URL: https://github.com/apache/felix-dev/pull/309#issuecomment-2088064547 We could do that, or i merge in your branch into mine and make the changes there? Then we have one PR with all the changes for both Jetty bundles. -- This is an automated message

Re: [PR] FELIX-6692 Add Jetty WebSocket support for jetty 11.x [felix-dev]

2024-04-30 Thread via GitHub
enapps-enorman commented on PR #309: URL: https://github.com/apache/felix-dev/pull/309#issuecomment-2088021350 > Update the README to document the new options for the Jetty 11 bundle I could do that but I guess I was thinking that it might be an awkward to merge with two PRs making ch

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-30 Thread via GitHub
paulrutter commented on PR #310: URL: https://github.com/apache/felix-dev/pull/310#issuecomment-2088016983 @cziegeler can you check out this PR and #309? Both are now aligned to use the same approach. Let me know you agree and this is good to merge for the next HTTP Jetty/Jetty12 release

Re: [PR] FELIX-6692 Add Jetty WebSocket support for jetty 11.x [felix-dev]

2024-04-30 Thread via GitHub
paulrutter commented on PR #309: URL: https://github.com/apache/felix-dev/pull/309#issuecomment-2088009357 The changes look good, only left would be to update the documentation to include the new settings. Update the README to document the new options for the Jetty 11 bundle (see htt

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-30 Thread via GitHub
paulrutter commented on code in PR #310: URL: https://github.com/apache/felix-dev/pull/310#discussion_r1585905806 ## http/jetty12/src/test/java/org/apache/felix/http/jetty/it/JettySpecificWebsocketIT.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-30 Thread via GitHub
enapps-enorman commented on code in PR #310: URL: https://github.com/apache/felix-dev/pull/310#discussion_r1585818887 ## http/jetty12/src/test/java/org/apache/felix/http/jetty/it/JettySpecificWebsocketIT.java: ## @@ -0,0 +1,211 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] FELIX-6692 Add Jetty WebSocket support for jetty 11.x [felix-dev]

2024-04-30 Thread via GitHub
enapps-enorman commented on PR #309: URL: https://github.com/apache/felix-dev/pull/309#issuecomment-2087899348 @paulrutter Thanks for working out the jetty12 stuff. I've made an attempt to integrate the code changes you suggested. -- This is an automated message from the Apache Git Servi

[jira] [Updated] (FELIX-6699) [DS] Excessive ERROR logging when Overlap in Service-Component header between wildcard and non-wildcard locations

2024-04-30 Thread Mark Adamcin (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Adamcin updated FELIX-6699: Description: When a bundle's Service-Component header contains explicit paths and wildcard paths,

[jira] [Updated] (FELIX-6699) [DS] Excessive ERROR logging when Overlap in Service-Component header between wildcard and non-wildcard locations

2024-04-30 Thread Mark Adamcin (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Adamcin updated FELIX-6699: Labels: patch-available (was: ) > [DS] Excessive ERROR logging when Overlap in Service-Component h

[PR] FELIX-6699 Skip parsing of repeated Service-Component entries [felix-dev]

2024-04-30 Thread via GitHub
adamcin opened a new pull request, #311: URL: https://github.com/apache/felix-dev/pull/311 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[jira] [Created] (FELIX-6699) [DS] Excessive ERROR logging when Overlap in Service-Component header between wildcard and non-wildcard locations

2024-04-30 Thread Mark Adamcin (Jira)
Mark Adamcin created FELIX-6699: --- Summary: [DS] Excessive ERROR logging when Overlap in Service-Component header between wildcard and non-wildcard locations Key: FELIX-6699 URL: https://issues.apache.org/jira/browse

[jira] [Commented] (FELIX-5310) Felix HTTP Jetty WebSockets do not work out of the box

2024-04-30 Thread BlueConic
[ https://issues.apache.org/jira/browse/FELIX-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842337#comment-17842337 ] Paul Rütter (BlueConic) commented on FELIX-5310: With the latest changes

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-30 Thread via GitHub
paulrutter commented on PR #310: URL: https://github.com/apache/felix-dev/pull/310#issuecomment-2084938020 I kept both examples in the whiteboard bundle, as both have value: * https://github.com/apache/felix-dev/pull/310/files#diff-a493047a289b4bd7db717df5c308a98988f0417824efa8819cf0e

Re: [PR] FELIX-6692 jetty 12.x websockets new approach (based on #309) [felix-dev]

2024-04-30 Thread via GitHub
paulrutter commented on code in PR #310: URL: https://github.com/apache/felix-dev/pull/310#discussion_r1584368518 ## http/jetty12/src/main/java/org/apache/felix/http/jetty/internal/JettyService.java: ## @@ -253,9 +253,12 @@ private void initializeJetty() throws Exception