Re: [PR] Replace Pax Logging with Logback in Pax Exam tests [felix-dev]

2025-05-12 Thread via GitHub
stbischof commented on PR #421: URL: https://github.com/apache/felix-dev/pull/421#issuecomment-2875221696 @laeubi can you please review before i merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Replace Pax Logging with Logback in Pax Exam tests [felix-dev]

2025-05-12 Thread via GitHub
stbischof commented on PR #421: URL: https://github.com/apache/felix-dev/pull/421#issuecomment-2875154471 This helps a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] FELIX-6778 Reduce number of re-creation(s) of SCR Component Registry thread [felix-dev]

2025-05-12 Thread via GitHub
laeubi commented on code in PR #419: URL: https://github.com/apache/felix-dev/pull/419#discussion_r2085971015 ## scr/src/main/java/org/apache/felix/scr/impl/ComponentRegistry.java: ## @@ -138,6 +142,17 @@ public ComponentRegistry( final ScrConfiguration scrConfiguration, final

Re: [PR] FELIX-6778 Reduce number of re-creation(s) of SCR Component Registry thread [felix-dev]

2025-05-12 Thread via GitHub
tjwatson commented on PR #419: URL: https://github.com/apache/felix-dev/pull/419#issuecomment-2873836447 > Another benefit is that the code becomes a bit simpler, as there is no need to cancel midway (nor the synchronisation that is currently present to ensure this happens consistently).

Re: [PR] FELIX-6778 Reduce number of re-creation(s) of SCR Component Registry thread [felix-dev]

2025-05-12 Thread via GitHub
glimmerveen commented on PR #419: URL: https://github.com/apache/felix-dev/pull/419#issuecomment-2873777981 > I need SCR on Java 8 for the now. > > Do we have performance metrics that show an improvement here? I don't have a specific performance metric I can refer to, but I did

Re: [PR] set loglevel to scr [felix-dev]

2025-05-12 Thread via GitHub
glimmerveen commented on PR #420: URL: https://github.com/apache/felix-dev/pull/420#issuecomment-2873747012 > Could you create. Pr of this? > > Or a fix hat makes it in a more modern way? I have just created #421 , could you have a look at it? -- This is an automated message

Re: [PR] FELIX-6778 Reduce number of re-creation(s) of SCR Component Registry thread [felix-dev]

2025-05-12 Thread via GitHub
tjwatson commented on PR #419: URL: https://github.com/apache/felix-dev/pull/419#issuecomment-2873269974 I need SCR on Java 8 for the now. Do we have performance metrics that show an improvement here? Can someone explain what `ds.service.changecount.timeout` controls? If I rea

[jira] [Commented] (FELIX-6776) Introduce way to restrict request and response size

2025-05-12 Thread Jira
[ https://issues.apache.org/jira/browse/FELIX-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950846#comment-17950846 ] Paul Rütter commented on FELIX-6776: [~cziegeler] are you ok with merging this? Since

Re: [PR] FELIX-6778 Reduce number of re-creation(s) of SCR Component Registry thread [felix-dev]

2025-05-12 Thread via GitHub
laeubi commented on PR #419: URL: https://github.com/apache/felix-dev/pull/419#issuecomment-2871187138 > a also like the idea to may move up from jdk 8 to ... I just wanted to mention that there is some hard work going on to keep the core OSGi framework at java 8, moving SCR to anythi

Re: [PR] FELIX-6778 Reduce number of re-creation(s) of SCR Component Registry thread [felix-dev]

2025-05-12 Thread via GitHub
cziegeler commented on PR #419: URL: https://github.com/apache/felix-dev/pull/419#issuecomment-2871180380 > @paulrutter a also like the idea to may move up from jdk 8 to ... but 21 is to much for the most projects. and really has to be discussed in he Project. @karlpauls @cziegeler f