Re: Gogo Shell Extensions

2012-02-12 Thread Felix Meschberger
Hi, Am 11.02.2012 um 20:40 schrieb Richard S. Hall: Felix, I think the FELIX-3340 certainly seems simple enough. ok As for FELIX-3341, it isn't too complex either, although I'm not familiar enough with the Gogo shell details to say whether or not this is the best approach for a

Re: Gogo Shell Extensions

2012-02-12 Thread Felix Meschberger
Hi, Am 11.02.2012 um 21:34 schrieb Derek Baum: These change look fine to me. Ultimately, I'd like to implement bash-style history and completion, but this requires putting the terminal into raw mode so that characters can be processed before newline is entered. Karaf uses jline to do this.

Re: Gogo Shell Extensions

2012-02-11 Thread Richard S. Hall
Felix, I think the FELIX-3340 certainly seems simple enough. As for FELIX-3341, it isn't too complex either, although I'm not familiar enough with the Gogo shell details to say whether or not this is the best approach for a history command, but it doesn't seem too invasive, so it would be

Re: Gogo Shell Extensions

2012-02-11 Thread Derek Baum
These change look fine to me. Ultimately, I'd like to implement bash-style history and completion, but this requires putting the terminal into raw mode so that characters can be processed before newline is entered. Karaf uses jline to do this. RFC147 (that gogo partially implements) specifies a

Re: Gogo Shell Extensions

2012-02-07 Thread Arjun Panday
Hi Felix, Out of curiosity, why the Adobe copyright notice? I haven't tried the patch but the history feature would be nice. -arjun On 02/07/2012 08:54 AM, Felix Meschberger wrote: Hi all, I created two extensions to the Felix Gogo Shell (FELIX-3340, FELIX-3341). Are there any concerns to

Gogo Shell Extensions

2012-02-06 Thread Felix Meschberger
Hi all, I created two extensions to the Felix Gogo Shell (FELIX-3340, FELIX-3341). Are there any concerns to my just applying the patches ? Regards Felix