Re: [PR] FELIX-6669 - proper detection of string property & comment boundaries… [felix-dev]

2023-11-13 Thread via GitHub
DominikSuess commented on PR #244: URL: https://github.com/apache/felix-dev/pull/244#issuecomment-1809186167 > @DominikSuess Do you handle the case where the string value contains a quote? you got me on that one - added test and fix -- This is an automated message from the Apache

Re: [PR] FELIX-6669 - proper detection of string property & comment boundaries… [felix-dev]

2023-11-13 Thread via GitHub
cziegeler commented on PR #244: URL: https://github.com/apache/felix-dev/pull/244#issuecomment-1809121233 @DominikSuess Do you handle the case where the string value contains a quote? ("\"" ?) -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] FELIX-6669 - proper detection of string property & comment boundaries… [felix-dev]

2023-11-13 Thread via GitHub
DominikSuess commented on PR #244: URL: https://github.com/apache/felix-dev/pull/244#issuecomment-1808980785 @rombert @cziegeler @bosschaert - as statet in the ticket I missed valid scenarios that were not covered by unit tests so far and being too consumed with the newline handling I

[PR] FELIX-6669 - proper detection of string property & comment boundaries… [felix-dev]

2023-11-13 Thread via GitHub
DominikSuess opened a new pull request, #244: URL: https://github.com/apache/felix-dev/pull/244 … to avoid mixing and false positive and false negative stripping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (FELIX-6669) Flaw in OOM Fix for JSON CommentStripping

2023-11-13 Thread Jira
Dominik Süß created FELIX-6669: -- Summary: Flaw in OOM Fix for JSON CommentStripping Key: FELIX-6669 URL: https://issues.apache.org/jira/browse/FELIX-6669 Project: Felix Issue Type: Bug

Re: [RESULT] [VOTE] Release Apache Felix cm.json 2.0.2

2023-11-13 Thread Robert Munteanu
On Mon, 2023-11-13 at 12:35 +, dav...@apache.org wrote: > Hi Robert, > > I've done the upload and promoted the artifacts in Nexus, they are > visible > here now: > https://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.cm.json/2.0.2/ Thanks, David! I also updated the Jira

Re: [RESULT] [VOTE] Release Apache Felix cm.json 2.0.2

2023-11-13 Thread davidb
Hi Robert, I've done the upload and promoted the artifacts in Nexus, they are visible here now: https://repo.maven.apache.org/maven2/org/apache/felix/org.apache.felix.cm.json/2.0.2/ Kind regards, David On Mon, 13 Nov 2023 at 10:01, Robert Munteanu wrote: > Hi, > > The vote has passed with

[jira] [Closed] (FELIX-6664) Comment Removing on JSONSupport MemoryInefficient

2023-11-13 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/FELIX-6664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed FELIX-6664. -- > Comment Removing on JSONSupport MemoryInefficient >

[RESULT] [VOTE] Release Apache Felix cm.json 2.0.2

2023-11-13 Thread Robert Munteanu
Hi, The vote has passed with the following result : +1 (binding): Carsten Ziegeler, Raymond Augé, Karl Pauls Can a Felix PMC member please upload the artifacts to the Felix dist directory? I will then promote the artifacts to the central Maven repository. Thanks! Robert