Re: Upgrade Gradle version used in Fineract

2019-02-22 Thread Vishwas Babu
On Fri, Feb 22, 2019 at 12:01 AM Juhan Aasaru wrote: > Hi! > > Vishwas and Myrle, thanks for explanations regarding Gradle version and > wrapper download instructions. > I first didn't notice that Michael had changed Gradle version inside > gradle-wrapper.properties > Instructions regarding downl

Re: Upgrade Gradle version used in Fineract

2019-02-22 Thread Juhan Aasaru
Hi! Vishwas and Myrle, thanks for explanations regarding Gradle version and wrapper download instructions. I first didn't notice that Michael had changed Gradle version inside gradle-wrapper.properties Instructions regarding downloading wrapper could include a line: "You only need to download wrap

Re: Upgrade Gradle version used in Fineract

2019-02-18 Thread Myrle Krantz
On Mon, Feb 18, 2019 at 8:39 PM Vishwas Babu < vish...@confluxtechnologies.com> wrote: > @Juhan : While I am not sure why the readme has instructions for > downloading gradle wrapper separately (given that it is a part of the > project repo and committed into the code), > ASF policy is that relea

Re: Upgrade Gradle version used in Fineract

2019-02-18 Thread Vishwas Babu
Hi Mike, One issue would be the removal of TaskInternal.execute() method in Gradle 5.x which is used in all DB related tasks (explicit call to flywayMigrate.execute() etc). @Juhan : While I am not sure why the readme has instructions for downloading gradle wrapper separately (given that it is a p

Re: Upgrade Gradle version used in Fineract

2019-02-18 Thread Juhan Aasaru
Hello Mike! That is a great initiative. I checked the pull request and I noticed something that you might want to take into account. Currently, Readme.md has instructions on how to download Gradle Wrapper. In my understanding, the correct Gradle Wrapper should be already committed to the code and

Upgrade Gradle version used in Fineract

2019-02-17 Thread Michael Vorburger
Hello, I would like to propose https://github.com/apache/fineract/pull/525 to upgrade the Gradle version used in Fineract. It would be good to get some reviews and perhaps manual testing from some people. I does of course build again (see the "green" PR, now that we have Travis CI integration), b