[jira] [Created] (FINERACT-156) After Waive specified due date charge (penalty) repayment schedule generated is not proper

2016-05-12 Thread subramanyasn (JIRA)
subramanyasn created FINERACT-156: - Summary: After Waive specified due date charge (penalty) repayment schedule generated is not proper Key: FINERACT-156 URL: https://issues.apache.org/jira/browse/FINERACT-156

RE: Review of Pull Request from James Rowe

2016-05-12 Thread Adi Raju
Hi James, Thanks for the clarifications. Going forward I would suggest starting a discussion on dev@fineract.incubator.apache.org to take decisions on a solution rather than taking PR path. Thanks, Adi From: James Rowe [mailto:jrowe...@gma

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread jroweboy
Github user jroweboy commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r63062104 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java --- @

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread jroweboy
Github user jroweboy commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r63061348 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java --- @

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread jroweboy
Github user jroweboy commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r63060689 --- Diff: fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/WorkingDays.java --- @@ -74,6 +78,8 @@ public Bool

[GitHub] incubator-fineract pull request: Multiselection for report paramet...

2016-05-12 Thread jinjurajan
GitHub user jinjurajan opened a pull request: https://github.com/apache/incubator-fineract/pull/115 Multiselection for report parameters You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinjurajan/incubator-fineract Reportparamet

[GitHub] incubator-fineract pull request: 293_post_interest_job

2016-05-12 Thread AvinashKumarG
Github user AvinashKumarG closed the pull request at: https://github.com/apache/incubator-fineract/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-fineract pull request: 293_post_interest_job

2016-05-12 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/103#discussion_r63004045 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularServiceImpl.java --- @@ -37,42 +41,

[GitHub] incubator-fineract pull request: 293_post_interest_job

2016-05-12 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/103#discussion_r63004091 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularServiceImpl.java --- @@ -37,42 +41,

[GitHub] incubator-fineract pull request: 293_post_interest_job

2016-05-12 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/103#discussion_r63003311 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountReadPlatformServiceImpl.java --- @@ -

[GitHub] incubator-fineract pull request: [MIFOSX-2652] Correcting repaymen...

2016-05-12 Thread Vishwa1311
GitHub user Vishwa1311 opened a pull request: https://github.com/apache/incubator-fineract/pull/114 [MIFOSX-2652] Correcting repayment schedule for the loans with variable installments enabled You can merge this pull request into a Git repository by running: $ git pull https:

RE: Review of Pull Request from James Rowe

2016-05-12 Thread Adi Raju
I have provided high level comments on the PR. PR cannot be taken in as is. I will ask the fellow community members to provide more comments on the core part of the solution. Regards, Adi From: Ed Cable [mailto:edca...@mifos.org] Sent: 11 May 2016 03:58 To: dev@fineract.incubator.apach

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r63000180 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java --- @@

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r6303 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java --- @@

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r62999753 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java --- @@

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r62999640 --- Diff: fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/WorkingDays.java --- @@ -41,15 +41,19 @@

[GitHub] incubator-fineract pull request: FINERACT-37 Reschedule payments t...

2016-05-12 Thread rajuan
Github user rajuan commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/110#discussion_r62999595 --- Diff: fineract-provider/src/main/java/org/apache/fineract/organisation/workingdays/domain/WorkingDays.java --- @@ -74,6 +78,8 @@ public Boolea

Re: [RESULT][VOTE] [FINERACT] 0.1.2-incubating for release

2016-05-12 Thread Nazeer Shaik
Thank you Myrle :-) On Thu, May 12, 2016 at 1:55 PM, Myrle Krantz wrote: > I believe you have a vote in this too Nazeer. So that would presumably be > total +5. > > Greets, > Myrle > > > *Myrle Krantz* > Solutions Architect > RɅĐɅЯ, The Mifos Initiative > mkra...@mifos.org | Skype: mkrantz.mifo

Re: [RESULT][VOTE] [FINERACT] 0.1.2-incubating for release

2016-05-12 Thread Myrle Krantz
I believe you have a vote in this too Nazeer. So that would presumably be total +5. Greets, Myrle *Myrle Krantz* Solutions Architect RɅĐɅЯ, The Mifos Initiative mkra...@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org On Thu,