Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Harbs
Ah. Thanks. (I haven’t had my coffee yet) ;-) It would be interesting to know if that really is more efficient. > On Aug 3, 2017, at 9:33 AM, Greg Dove wrote: > > I assume it is if (unknownNumOrNaN != unknownNumOrNaN ) > > I have used things like if (unknownNumOrNaN *0 !=0) in the past but the

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Greg Dove
I assume it is if (unknownNumOrNaN != unknownNumOrNaN ) I have used things like if (unknownNumOrNaN *0 !=0) in the past but the above seems better On Thu, Aug 3, 2017 at 6:20 PM, Harbs wrote: > I’m curious. How does that work? > unknownNumOrNaN != NaN will always be true > > > On Aug 3, 2017,

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Harbs
I’m curious. How does that work? unknownNumOrNaN != NaN will always be true > On Aug 3, 2017, at 1:37 AM, Josh Tynjala wrote: > > Good one! To avoid the overhead of the isNaN() function call, I frequently > rely on the fact that NaN != NaN. > > - Josh > > On Wed, Aug 2, 2017 at 3:32 PM, Harbs

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-02 Thread Alex Harui
OK, I think we've tried everything we know how to do, so please see if Infra can help us. Thanks, -Alex On 8/2/17, 12:16 AM, "piotrz" wrote: >Issue has been fixed, but main problem is still there. If anyone do not >have >more idea what is happening here is what I'm going to do: > >1) I will con

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-02 Thread Alex Harui
I think I have that fixed locally. Now I am having a problem with the integration-tests and Java version. Once I get past that I can compare my results against the CI server's results. -Alex On 8/2/17, 4:22 PM, "piotrz" wrote: >Hi Alex, > >It's failing for me exactly same and I think it shoul

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-02 Thread piotrz
Hi Alex, It's failing for me exactly same and I think it should be fixed in class which is running those tests. I switched MDLExample to build JSFlex only. Tests running by Maven Surefire Plugin are here -> "flex-asjs\examples\examples-tests\src\main\java\org\apache\flex\flexjs\examples\tests\Exam

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Josh Tynjala
I like the idea of having the FlexJS framework specify non-initialization with its config files, and then most users will get initialization by default (obviously, with the option to have non-initialization too, if desired). - Josh On Wed, Aug 2, 2017 at 2:16 PM, Alex Harui wrote: > We have fle

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Josh Tynjala
Good one! To avoid the overhead of the isNaN() function call, I frequently rely on the fact that NaN != NaN. - Josh On Wed, Aug 2, 2017 at 3:32 PM, Harbs wrote: > Thanks for the history lesson. :-) > > This does bring up another difference between an initialized value of NaN > and undefined: >

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Harbs
https://jonnyjordan.com/blog/remove-send-email-button-off-macbook-2016-touch-bar-apple-mail/ > On Aug 3, 2017, at 1:00 AM, Dave Fisher wrote: > > I hate this Macbook’s touch top bar which puts a send

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Harbs
Thanks for the history lesson. :-) This does bring up another difference between an initialized value of NaN and undefined: NaN != NaN, while undefined == undefined > On Aug 3, 2017, at 1:00 AM, Dave Fisher wrote: > > I hate this Macbook’s touch top bar which puts a send button directly above

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Dave Fisher
I hate this Macbook’s touch top bar which puts a send button directly above the delete key. > On Aug 2, 2017, at 2:50 PM, Dave Fisher wrote: > > Hi Folks, > > A peanut gallery look at NaN which is really a bit encoding for various kinds > of floating point number errors like underflow, overfl

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Dave Fisher
Hi Folks, A peanut gallery look at NaN which is really a bit encoding for various kinds of floating point number errors like underflow, overflow, divided by 0, etc. In my Fortran past life we used XMISS as a special valu > On Aug 1, 2017, at 3:21 PM, Greg Dove wrote: > > Yes it does. NaN is a

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Alex Harui
We have flex-config.xml, air-config.xml, js-config.xml, etc. These config files are (or can be) different sets of defaults. Meanwhile, we currently build the FlexJS framework via compile-swf-config.xml and compile-js-config.xml and its equivalent in pom.xml. I have no problem using different def

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-02 Thread Alex Harui
Hi Piotr, This Maven build is running the distribution profile. The command line is something like: mvn clean install sonar:sonar -P "build-examples,build-distribution" -Dcom.adobe.systemIdsForWhichTheTermsOfTheAdobeLicenseAgreementAreAccepted= 3872fc1e -Dwebdriver.gecko.driver=F:\jenkins\tools

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Josh Tynjala
> To me, this is all related to PAYG. To me, making the compiler generate PAYG code by default sounds like the FlexJS framework leaking into the rest of the ecosystem. Maybe this is a place where mxmlc and asjsc should go in different directions. It makes perfect sense to me for the compiler to do

RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API

2017-08-02 Thread Yishay Weiss
I don’t think those lines would be enough for all MDL controls. We’re only using a subset. From: piotrz Sent: Wednesday, August 2, 2017 2:02 PM To: dev@flex.apache.org Subject: RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer

RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API

2017-08-02 Thread piotrz
Yishay, I think I will create jira and add those css to MDL in order to get rid off that ugly line with exclusion. Anyone seeing some danger doing that ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread piotrz
I really like Alex's proposition where we could have list of classes which should be initialized. Actually why do not have both? One global variable which makes all initialized or list of initialized. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Harbs
> My guess is that they would prefer to avoid 'Pain as you go' from incompatible > as3 justified by pay as you go. > The challenge for us then is to come up with the optimizations that both > you and Alex have mentioned, so that wherever possible the unneccessary > initializations are not expressed

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Harbs
Yes. I just tried the new compiler option and I can confirm that this is the case. Only local variables are initialized. Additionally: This: var len:int; Compiles to: var /** @type {number} */ len = 0 = null; > On Aug 2, 2017, at 7:34 AM, Alex Harui wrote: > > BTW, IIRC, VarDeclarationEmitter

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Greg Dove
That sounds great Harbs. It will be interesting to see the gzip comparisons. I suspect that there would have to be massive quantities of redundant initializations to cause a meaningful performance impact, but keen to see the data. >From my perspective I think the baseline should be as3 compatibil

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

2017-08-02 Thread Harbs
I’m planning on using the new compiler options to compile my app with and without initialization. I want to compare the app size of those two options after gzipping to see if there’s an impact on code size. I’d also like to write up a doc with the pros and cons of both approaches and see if I c

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

2017-08-02 Thread piotrz
Issue has been fixed, but main problem is still there. If anyone do not have more idea what is happening here is what I'm going to do: 1) I will contact with infra on ChipChat and ask whether they are seeing if it is problem on their sight If NOT 2) I will ask some people on the other projects - W