Re: [1/3] git commit: [flex-sdk] - FLEX-24411 FLEX-20322 added support for .milliseconds and fix parsing of international months

2013-04-22 Thread Justin Mclean
HI, >> True but how many dates do you need to parse in a second? Plus I was keeping >> to existing code style. > Not sure. Like I said, it is optional Raise it as a minor JIRA and I'll eventually get to it. > , and I forgot to say thanks for plowing through all of this broken date > stuff. Rath

Re: [1/3] git commit: [flex-sdk] - FLEX-24411 FLEX-20322 added support for .milliseconds and fix parsing of international months

2013-04-22 Thread Alex Harui
On 4/22/13 8:26 AM, "Justin Mclean" wrote: > Hi, > >> This many checks in an if statement usually runs faster if you do a simple >> lookup. > True but how many dates do you need to parse in a second? Plus I was keeping > to existing code style. Not sure. Like I said, it is optional, and I fo

Re: [1/3] git commit: [flex-sdk] - FLEX-24411 FLEX-20322 added support for .milliseconds and fix parsing of international months

2013-04-22 Thread Justin Mclean
Hi, > This many checks in an if statement usually runs faster if you do a simple > lookup. True but how many dates do you need to parse in a second? Plus I was keeping to existing code style. I not measured how long parseDateString takes but I assume it;s only a few ms if that. Justin

Re: [1/3] git commit: [flex-sdk] - FLEX-24411 FLEX-20322 added support for .milliseconds and fix parsing of international months

2013-04-22 Thread Alex Harui
Bonus optimization if you have time for this pattern: > +if (!("0" <= letter && letter <= "9" || > + letter == "/" || letter == ":" || > + letter == "+" || letter == "-" || > + letter == "." || letter == " ")) This many checks in an if