Re: [FlexJS][Maven] Build failure caused by compiler warnings (was: Re: [FlexJS] How Binding works?)

2016-12-09 Thread Christofer Dutz
I just comitted a change to allow a return value of 2 in flexjs-compiler/flexjs-maven-plugin/src/main/java/org/apache/flex/maven/flexjs/BaseMojo.java (Line 227) Chris Am 09.12.16, 22:00 schrieb "Alex Harui" : On 12/9/16, 11:54 AM, "Christofer Dutz"

Re: [FlexJS][Maven] Build failure caused by compiler warnings (was: Re: [FlexJS] How Binding works?)

2016-12-09 Thread Alex Harui
On 12/9/16, 11:54 AM, "Christofer Dutz" wrote: >The maven build will not fail because of this. All it does is output >warnings. > >If it does fail, this is definitely something we need to fix. I observed that the SWF build output the warning and apparently did not

Re: [FlexJS][Maven] Build failure caused by compiler warnings (was: Re: [FlexJS] How Binding works?)

2016-12-09 Thread Christofer Dutz
The maven build will not fail because of this. All it does is output warnings. If it does fail, this is definitely something we need to fix. Chris Am 09.12.16, 19:50 schrieb "Alex Harui" : On 12/9/16, 10:25 AM, "carlos.rov...@gmail.com on behalf of Carlos

Re: [FlexJS][Maven] Build failure caused by compiler warnings (was: Re: [FlexJS] How Binding works?)

2016-12-09 Thread Alex Harui
On 12/9/16, 11:04 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >Even if the class as marked as Bindable? If I understand your plan, yes. When you write {data.foo}, the binding system is trying to detect not only changes

Re: [FlexJS][Maven] Build failure caused by compiler warnings (was: Re: [FlexJS] How Binding works?)

2016-12-09 Thread OmPrakash Muppirala
Even if the class as marked as Bindable? On Fri, Dec 9, 2016 at 11:03 AM, Alex Harui wrote: > > > On 12/9/16, 10:59 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" > wrote: > > >On Fri, Dec 9, 2016 at 10:50 AM,

Re: [FlexJS][Maven] Build failure caused by compiler warnings (was: Re: [FlexJS] How Binding works?)

2016-12-09 Thread Alex Harui
On 12/9/16, 10:59 AM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >On Fri, Dec 9, 2016 at 10:50 AM, Alex Harui wrote: >> >> The binding warning is legitimate. It says that there aren't change >> events for

Re: [FlexJS][Maven] Build failure caused by compiler warnings (was: Re: [FlexJS] How Binding works?)

2016-12-09 Thread OmPrakash Muppirala
On Fri, Dec 9, 2016 at 10:50 AM, Alex Harui wrote: > > > On 12/9/16, 10:25 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" > wrote: > > >You're right, compile is working, but message was confused (BUILD

Re: [FlexJS][Maven] Build failure caused by compiler warnings (was: Re: [FlexJS] How Binding works?)

2016-12-09 Thread Alex Harui
On 12/9/16, 10:25 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >You're right, compile is working, but message was confused (BUILD FAILURE) > >Maybe Chris could help with this? Well, I'm sure he can, but Chris did

[FlexJS][Maven] Build failure caused by compiler warnings (was: Re: [FlexJS] How Binding works?)

2016-12-09 Thread Carlos Rovira
You're right, compile is working, but message was confused (BUILD FAILURE) Maybe Chris could help with this? 2016-12-09 17:48 GMT+01:00 Alex Harui : > Well, that is a legitimate warning, but is innocuous. I'm tempted to try > to figure out how to tell Maven to accept these