Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Alex Harui
Let's make sure we understand the problem. It is always tempting to add more things to the base classes, but IMO we have to keep in mind that we want to use PAYG as much as possible, and use composition more than subclassing. At the lowest level, the Basic set isn't being designed for folks doing

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread OmPrakash Muppirala
On Jan 15, 2017 11:50 AM, "Carlos Rovira" wrote: Hi Om, 2017-01-15 19:58 GMT+01:00 OmPrakash Muppirala : > > I prefer we create a ComponentUIBase based on UIBase and add this logic > here. And make all components extend ComponentUIBase instead of UIBase. > > But considere that at least in MDL w

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Carlos Rovira
Thanks Josh, currently seems this method is not used at all in FlexJS, since a search doesn't show any ocurrence... maybe we could make UIBase to use ENTER_FRAME for SWF and this other one for JS? (even unify both under "ENTER_FRAME" event?) 2017-01-15 21:45 GMT+01:00 Josh Tynjala : > requestAni

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Josh Tynjala
requestAnimationFrame() is the web browser equivalent of Flash's Event.ENTER_FRAME. https://developer.mozilla.org/en-US/docs/Web/API/window/requestAnimationFrame - Josh On Jan 15, 2017 11:50 AM, "Carlos Rovira" wrote: Hi Om, 2017-01-15 19:58 GMT+01:00 OmPrakash Muppirala : > > I prefer we c

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Carlos Rovira
Hi Om, 2017-01-15 19:58 GMT+01:00 OmPrakash Muppirala : > > I prefer we create a ComponentUIBase based on UIBase and add this logic > here. And make all components extend ComponentUIBase instead of UIBase. > > But considere that at least in MDL we are in many cases extending FlexJS basic componen

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread OmPrakash Muppirala
internal list. If I understand correct it will > be > list which merges both things? > > Adding aditional could mess up some components - I think Tab, but not sure. > > Piotr > > > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > Vi

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread Carlos Rovira
both things? > > Adding aditional could mess up some components - I think Tab, but not sure. > > Piotr > > > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in context: http://apache-flex- > development.247.n4.nabbl

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread piotrz
- Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-className-problem-with-MDL-properties-that-modifies-component-className-tp58284p58311.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-15 Thread OmPrakash Muppirala
On Jan 14, 2017 11:07 PM, "Alex Harui" wrote: On 1/14/17, 10:56 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >Thinking about this more, we could enclose components in a container div. >The component would have the frozen styles and any classnames the user >sets >would would

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-14 Thread Alex Harui
On 1/14/17, 10:56 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >Thinking about this more, we could enclose components in a container div. >The component would have the frozen styles and any classnames the user >sets >would would be on the parent div. This way, due to the cas

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-14 Thread OmPrakash Muppirala
Thinking about this more, we could enclose components in a container div. The component would have the frozen styles and any classnames the user sets would would be on the parent div. This way, due to the cascading nature of CSS, the component would get the appropriate styles while maintaining the

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-14 Thread Alex Harui
On 1/14/17, 7:54 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi Om, Alex, > >thanks for the suggestions but that not work. After sleep and thin about >it >a little more my understanding is that this is really not a problem of >malfunctioning, is simply that we have properti

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-14 Thread Carlos Rovira
Hi Om, Alex, thanks for the suggestions but that not work. After sleep and thin about it a little more my understanding is that this is really not a problem of malfunctioning, is simply that we have properties that operates visual changes based on CSS, so the right way is yo apply the instruction

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-13 Thread Alex Harui
typeNames are classSelectors meant to act like TypeSelectors. Like DataGrid or DropDownList. If the customer sets className it shouldn't affect typeNames. Can the customer also use the classList API? If so, then you may need yet another thing like typeNames like "internalClassNames" which is th

Re: [FlexJS] className problem with MDL properties that modifies component className

2017-01-13 Thread OmPrakash Muppirala
On Jan 13, 2017 6:30 PM, "Carlos Rovira" wrote: Hi, found an issue with MDL and custom class. If you declare a component that has some new custom additional class (lets call "someClass"), and has some property that modifies the className (in our case always through classList API), let's say is

[FlexJS] className problem with MDL properties that modifies component className

2017-01-13 Thread Carlos Rovira
Hi, found an issue with MDL and custom class. If you declare a component that has some new custom additional class (lets call "someClass"), and has some property that modifies the className (in our case always through classList API), let's say is a button, and this is the example: the result i