[FlexJS] Image changes

2017-02-10 Thread Peter Ent
I've made the following changes on the flex-asjs develop branch: Image control now uses "src" property instead of "url" property to match tag. ImageButton control now uses "src" property instead of "source" property to be consistent with Image control. I did not touch the ImageAndTextButton c

Re: [FlexJS] Image source vs src vs url

2017-02-08 Thread Peter Ent
That's why I picked src to begin with. I think that is a better choice, if Harbs and anyone else doesn't mind. Think about it and I'll start the work tomorrow. —peter On 2/8/17, 2:53 PM, "omup...@gmail.com on behalf of OmPrakash Muppirala" wrote: >In HTML/JS world, src is used on the HTML img ta

Re: [FlexJS] Image source vs src vs url

2017-02-08 Thread OmPrakash Muppirala
In HTML/JS world, src is used on the HTML img tag. The same can be done in CSS where you need to use url. In our world, I prefer src as people might be more familiar with that. Thanks, Om On Wed, Feb 8, 2017 at 11:48 AM, Peter Ent wrote: > Would you prefer it to be url? I am not concerned tha

Re: [FlexJS] Image source vs src vs url

2017-02-08 Thread Peter Ent
Would you prefer it to be url? I am not concerned that much, except I think all of the Image-related components should have the same property. —peter On 2/8/17, 1:58 PM, "Harbs" wrote: >We will have to change the code in our app, but I think that’s ok. > >> On Feb 8, 2017, at 8:25 PM, Peter Ent

Re: [FlexJS] Image source vs src vs url

2017-02-08 Thread Harbs
We will have to change the code in our app, but I think that’s ok. > On Feb 8, 2017, at 8:25 PM, Peter Ent wrote: > > I forgot about ImageAndTextButton. That uses "image" to specify the > location. So there's yet another property. > > ‹peter > > On 2/8/17, 1:23 PM, "Peter Ent" wrote: > >> Hi

Re: [FlexJS] Image source vs src vs url

2017-02-08 Thread Peter Ent
I forgot about ImageAndTextButton. That uses "image" to specify the location. So there's yet another property. ‹peter On 2/8/17, 1:23 PM, "Peter Ent" wrote: >Hi, > >I'm working the TourJS and needed to make some changes to ImageButton. I >see that Image uses url to specify the location of the i

[FlexJS] Image source vs src vs url

2017-02-08 Thread Peter Ent
Hi, I'm working the TourJS and needed to make some changes to ImageButton. I see that Image uses url to specify the location of the image while ImageButton uses source. Meanwhile, HTML uses src. I find this to be confusing. I would like to switch Image and ImageButton to src. I recall a discus

RE: [FlexJS] Image on JS platform

2016-12-17 Thread Yishay Weiss
This [1] works for me [1] https://paste.apache.org/61AK From: Peter Ent<mailto:p...@adobe.com> Sent: Friday, December 16, 2016 11:19 PM To: dev@flex.apache.org<mailto:dev@flex.apache.org> Subject: Re: [FlexJS] Image on JS platform I meant url. I did not use src. On 12/16

Re: [FlexJS] Image on JS platform

2016-12-16 Thread Peter Ent
I meant url. I did not use src. On 12/16/16, 2:39 PM, "Yishay Weiss" wrote: >Have you tried url instead of src? > > > >From: Peter Ent<mailto:p...@adobe.com> >Sent: Friday, December 16, 2016 9:23 PM >To: dev@flex.apache.org<mailto:dev@flex.apache.org&

RE: [FlexJS] Image on JS platform

2016-12-16 Thread Yishay Weiss
Have you tried url instead of src? From: Peter Ent<mailto:p...@adobe.com> Sent: Friday, December 16, 2016 9:23 PM To: dev@flex.apache.org<mailto:dev@flex.apache.org> Subject: [FlexJS] Image on JS platform I'm trying to use and no image is being loaded. Looking at the Ima

[FlexJS] Image on JS platform

2016-12-16 Thread Peter Ent
I'm trying to use and no image is being loaded. Looking at the ImageBase.as code, I don't see how the image src is making it to the element that has been created. Is there a part I'm missing or is something disconnected? I'm happy to fix it, I just didn't want to undo something that should be

Re: [FlexJS|Image] Missing properties in created Image

2016-12-07 Thread Alex Harui
On 12/7/16, 7:26 AM, "carlos.rov...@gmail.com on behalf of Carlos Rovira" wrote: >Hi, Right now MDL is JS only, but I think one day we could make a Flash >version, for that reason I think we should develop with that in mind. Well, in the rest of the code, we generally try to make the JS output

Re: [FlexJS|Image] Missing properties in created Image

2016-12-07 Thread Carlos Rovira
Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in context: http://apache-flex- > development.247.n4.nabble.com/FlexJS-Image-Missing- > properties-in-created-Image-tp57045p57047.html > Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS|Image] Missing properties in created Image

2016-12-06 Thread piotrz
Thanks Alex. I will use HTMLImageElement. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Image-Missing-properties-in-created-Image-tp57045p57047.html Sent from the Apache Flex Development

Re: [FlexJS|Image] Missing properties in created Image

2016-12-06 Thread Alex Harui
On 12/6/16, 9:53 PM, "piotrz" wrote: >Hi, > >In one of the MDL component I've created org.apache.flex.html.Image. I see >in code that this image has > >"imageElement" property and "applyImageData", but I don't see them in >compiled swc. If I use them simply > >var image:Image = new Image(); >im

[FlexJS|Image] Missing properties in created Image

2016-12-06 Thread piotrz
View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Image-Missing-properties-in-created-Image-tp57045.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: AW: [FlexJS]Image

2016-09-13 Thread Peter Ent
suite including examples ... as soon >as that passes, I'll commit my changes. > > >Chris > > >Von: Christofer Dutz >Gesendet: Dienstag, 13. September 2016 10:19:38 >An: dev@flex.apache.org >Betreff: AW: [FlexJS]Image > >I think

AW: [FlexJS]Image

2016-09-13 Thread Christofer Dutz
etreff: AW: [FlexJS]Image I think those last changes broke the framework build: https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Framework%20(maven)/255/console Chris Von: Harbs Gesendet: Montag, 12. September 2016 20:11:18 An: dev@flex.apache.org Betreff: R

AW: [FlexJS]Image

2016-09-13 Thread Christofer Dutz
I think those last changes broke the framework build: https://builds.apache.org/view/E-G/view/Flex/job/FlexJS%20Framework%20(maven)/255/console Chris Von: Harbs Gesendet: Montag, 12. September 2016 20:11:18 An: dev@flex.apache.org Betreff: Re: [FlexJS]Image

Re: [FlexJS]Image

2016-09-12 Thread Harbs
Thanks. I’ll clean up BinaryImage as well when I have the opportunity. On Sep 12, 2016, at 8:35 PM, Peter Ent wrote: > I updated the defaults.css in the HTML project to include the Image's > model and view for SWF and JS and removed this code fragment. > ―peter > > On 9/12/16, 10:01 AM, "Peter

Re: [FlexJS]Image

2016-09-12 Thread Peter Ent
I updated the defaults.css in the HTML project to include the Image's model and view for SWF and JS and removed this code fragment. ―peter On 9/12/16, 10:01 AM, "Peter Ent" wrote: >I had to go back and look into it all again. This code is necessary. The >source property is actually stored in the

Re: [FlexJS]Image

2016-09-12 Thread Peter Ent
I had to go back and look into it all again. This code is necessary. The source property is actually stored in the image's model. When this property changes, the ImageView bead picks it up and sets it into the element, so the ImageView bead is also necessary; the Image needs the view in order to d

Re: [FlexJS]Image

2016-09-12 Thread Peter Ent
I'll have to see what happens when these lines are removed. The Flash side nearly always has model and view beads to build the components but the JS side may not have a view bead since the element (i.e., ) is the view. Meaning, the Flash and JS versions aren't always symmetric. I'm not really sure

[FlexJS]Image

2016-09-12 Thread Harbs
The Image component has the following code which did not make a lot of sense to me considering it’s JS-only: model = new ImageModel(); addBead(new ImageView()); When trying to figure this out, we realized that this should be in